Skip to content

Fix chunked reading of request body #9065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobias-tengler merged 2 commits into from
Jan 26, 2026
Merged

Fix chunked reading of request body #9065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da52091
Fix chunked reading of request body
tobias-tengler Jan 26, 2026
59b9d05
Fix other instance
tobias-tengler Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/HotChocolate/Adapters/src/Adapters.OpenApi.Core/Execution/DynamicEndpointMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,9 @@ await Results.Problem(
var memory = writer.GetMemory(chunkSize);
read = await body.ReadAsync(memory, cancellationToken).ConfigureAwait(false);
writer.Advance(read);
} while (read != 0);

// if (_maxRequestSize < writer.Length)
// {
// throw DefaultHttpRequestParser_MaxRequestSizeExceeded();
// }
} while (read == chunkSize);

if (read == 0)
if (writer.Length == 0)
{
throw new BadRequestException("Expected to have a body");
}
Expand Down
6 changes: 3 additions & 3 deletions src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Parsers/DefaultHttpRequestParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public async ValueTask<GraphQLRequest> ParsePersistedOperationRequestAsync(
{
const int chunkSize = 256;
using var writer = new PooledArrayWriter();
var read = 0;
int read;

do
{
Expand All @@ -72,7 +72,7 @@ public async ValueTask<GraphQLRequest> ParsePersistedOperationRequestAsync(
{
throw DefaultHttpRequestParser_MaxRequestSizeExceeded();
}
} while (read == chunkSize);
} while (read != 0);
Comment thread
tobias-tengler marked this conversation as resolved.

if (writer.Length == 0)
{
Expand Down Expand Up @@ -309,7 +309,7 @@ private async ValueTask<IReadOnlyList<GraphQLRequest>> ReadAsync(
{
throw DefaultHttpRequestParser_MaxRequestSizeExceeded();
}
} while (read == chunkSize);
} while (read != 0);

if (writer.Length == 0)
{
Expand Down
Loading