Prefer comparing to interfaces#8972
Closed
tscott-servicetitan wants to merge 3 commits intoChilliCream:mainfrom
Closed
Prefer comparing to interfaces#8972tscott-servicetitan wants to merge 3 commits intoChilliCream:mainfrom
tscott-servicetitan wants to merge 3 commits intoChilliCream:mainfrom
Conversation
michaelstaib
requested changes
Dec 4, 2025
Member
michaelstaib
left a comment
michaelstaib
left a comment
There was a problem hiding this comment.
Not sure if this is a good idea... there are several guarantees around ResponseStream and OperationResult. Lets wait on this until we are further with 16 ... for 15 we cannot change it. For 16 I want to have a clearer picture where we are heading with result types as we are currently working on this: #8931
Author
|
Makes sense, I thought that may be the case. Thank you for taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using a separate (custom)
IResponseStreamthis check will fail. Rather, we can allow this check to pass as long asIResponseStreamis implemented.Note
Not sure is this is safe/ok. I came across this issue in my own unit tests after implementing my own custom
IResponseStream. Within the middleware, I will replace the original (context.Result) ResponseStream within a wrapper of my own making.