Skip to content

[Fusion] Fix __Directive.locations and __Type.ofType resolvers #8751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 30, 2025
Merged

[Fusion] Fix __Directive.locations and __Type.ofType resolvers #8751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
470d15b
Fix duplicated UseOperationExecution in default pipeline
tobias-tengler Sep 30, 2025
5c744fa
Add introspection tests
tobias-tengler Sep 30, 2025
7769654
Add RawListFieldResult for directive locations
tobias-tengler Sep 30, 2025
04c67bd
Fix ofType resolver
tobias-tengler Sep 30, 2025
3d0db0a
Improve test
tobias-tengler Sep 30, 2025
9b36367
Add descriptions and deprecations
tobias-tengler Sep 30, 2025
aa11e10
Merge branch 'main' into tte/fusion-fix-introspection
tobias-tengler Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 64 additions & 48 deletions src/HotChocolate/Core/test/Execution.Tests/__resources__/IntrospectionQuery.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,67 +1,78 @@
query IntrospectionQuery {
__schema {
queryType { name }
mutationType { name }
subscriptionType { name }
types {
...FullType
}
directives {
name
description
args(includeDeprecated: true) {
...InputValue
}
onOperation
onFragment
onField
}
query IntrospectionQuery {
__schema {
queryType {
name
}
}

fragment FullType on __Type {
kind
name
description
fields(includeDeprecated: true) {
mutationType {
name
description
args(includeDeprecated: true) {
...InputValue
}
type {
...TypeRef
}
isDeprecated
deprecationReason
}
inputFields(includeDeprecated: true) {
...InputValue
subscriptionType {
name
}
interfaces {
...TypeRef
types {
...FullType
}
enumValues(includeDeprecated: true) {
directives {
name
description
isDeprecated
deprecationReason
isRepeatable
args(includeDeprecated: true) {
...InputValue
}
locations
onOperation
onFragment
onField
}
possibleTypes {
}
}
fragment FullType on __Type {
kind
name
description
specifiedByURL
fields(includeDeprecated: true) {
name
description
args(includeDeprecated: true) {
...InputValue
}
type {
...TypeRef
}
isDeprecated
deprecationReason
}
inputFields(includeDeprecated: true) {
...InputValue
}

fragment InputValue on __InputValue {
interfaces {
...TypeRef
}
enumValues(includeDeprecated: true) {
name
description
type { ...TypeRef }
defaultValue
isDeprecated
deprecationReason
}

fragment TypeRef on __Type {
possibleTypes {
...TypeRef
}
}
fragment InputValue on __InputValue {
name
description
type {
...TypeRef
}
defaultValue
isDeprecated
deprecationReason
}
fragment TypeRef on __Type {
kind
name
ofType {
kind
name
ofType {
Expand All @@ -73,7 +84,12 @@
ofType {
kind
name
ofType {
kind
name
}
}
}
}
}
}
46 changes: 41 additions & 5 deletions ...Core/test/Execution.Tests/__snapshots__/IntrospectionTests.DefaultValueIsInputObject.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"kind": "OBJECT",
"name": "__Directive",
"description": "A Directive provides a way to describe alternate runtime execution and type validation behavior in a GraphQL document.\n\nIn some cases, you need to provide options to alter GraphQL's execution behavior in ways field arguments will not suffice, such as conditionally including or skipping a field. Directives provide this by describing additional information to the executor.",
"specifiedByURL": null,
"fields": [
{
"name": "name",
Expand Down Expand Up @@ -55,7 +56,8 @@
"name": null,
"ofType": {
"kind": "ENUM",
"name": "__DirectiveLocation"
"name": "__DirectiveLocation",
"ofType": null
}
}
}
Expand Down Expand Up @@ -95,7 +97,8 @@
"name": null,
"ofType": {
"kind": "OBJECT",
"name": "__InputValue"
"name": "__InputValue",
"ofType": null
}
}
}
Expand Down Expand Up @@ -177,6 +180,7 @@
"kind": "ENUM",
"name": "__DirectiveLocation",
"description": "A Directive can be adjacent to many parts of the GraphQL language, a __DirectiveLocation describes one such possible adjacencies.",
"specifiedByURL": null,
"fields": null,
"inputFields": null,
"interfaces": null,
Expand Down Expand Up @@ -302,6 +306,7 @@
"kind": "OBJECT",
"name": "__EnumValue",
"description": "One possible value for a given Enum. Enum values are unique values, not a placeholder for a string or numeric value. However an Enum value is returned in a JSON response as a string.",
"specifiedByURL": null,
"fields": [
{
"name": "name",
Expand Down Expand Up @@ -369,6 +374,7 @@
"kind": "OBJECT",
"name": "__Field",
"description": "Object and Interface types are described by a list of Fields, each of which has a name, potentially a list of arguments, and a return type.",
"specifiedByURL": null,
"fields": [
{
"name": "name",
Expand Down Expand Up @@ -430,7 +436,8 @@
"name": null,
"ofType": {
"kind": "OBJECT",
"name": "__InputValue"
"name": "__InputValue",
"ofType": null
}
}
}
Expand Down Expand Up @@ -492,6 +499,7 @@
"kind": "OBJECT",
"name": "__InputValue",
"description": "Arguments provided to Fields or Directives and the input fields of an InputObject are represented as Input Values which describe their type and optionally a default value.",
"specifiedByURL": null,
"fields": [
{
"name": "name",
Expand Down Expand Up @@ -587,6 +595,7 @@
"kind": "OBJECT",
"name": "__Schema",
"description": "A GraphQL Schema defines the capabilities of a GraphQL server. It exposes all available types and directives on the server, as well as the entry points for query, mutation, and subscription operations.",
"specifiedByURL": null,
"fields": [
{
"name": "description",
Expand Down Expand Up @@ -615,7 +624,8 @@
"name": null,
"ofType": {
"kind": "OBJECT",
"name": "__Type"
"name": "__Type",
"ofType": null
}
}
}
Expand Down Expand Up @@ -678,7 +688,8 @@
"name": null,
"ofType": {
"kind": "OBJECT",
"name": "__Directive"
"name": "__Directive",
"ofType": null
}
}
}
Expand All @@ -696,6 +707,7 @@
"kind": "OBJECT",
"name": "__Type",
"description": "The fundamental unit of any GraphQL Schema is the type. There are many kinds of types in GraphQL as represented by the `__TypeKind` enum.\n\nDepending on the kind of a type, certain fields describe information about that type. Scalar types provide no information beyond a name and description, while Enum types provide their values. Object and Interface types provide the fields they describe. Abstract types, Union and Interface, provide the Object types possible at runtime. List and NonNull types compose other types.",
"specifiedByURL": null,
"fields": [
{
"name": "kind",
Expand Down Expand Up @@ -934,6 +946,7 @@
"kind": "ENUM",
"name": "__TypeKind",
"description": "An enum describing what kind of type a given `__Type` is.",
"specifiedByURL": null,
"fields": null,
"inputFields": null,
"interfaces": null,
Expand Down Expand Up @@ -993,6 +1006,7 @@
"kind": "OBJECT",
"name": "Bar",
"description": null,
"specifiedByURL": null,
"fields": [
{
"name": "a",
Expand Down Expand Up @@ -1029,6 +1043,7 @@
"kind": "SCALAR",
"name": "String",
"description": "The `String` scalar type represents textual data, represented as UTF-8 character sequences. The String type is most often used by GraphQL to represent free-form human-readable text.",
"specifiedByURL": null,
"fields": null,
"inputFields": null,
"interfaces": null,
Expand All @@ -1039,6 +1054,7 @@
"kind": "SCALAR",
"name": "Boolean",
"description": "The `Boolean` scalar type represents `true` or `false`.",
"specifiedByURL": null,
"fields": null,
"inputFields": null,
"interfaces": null,
Expand All @@ -1049,6 +1065,7 @@
"kind": "INPUT_OBJECT",
"name": "Baz",
"description": null,
"specifiedByURL": null,
"fields": null,
"inputFields": [
{
Expand All @@ -1073,6 +1090,7 @@
{
"name": "skip",
"description": "Directs the executor to skip this field or fragment when the `if` argument is true.",
"isRepeatable": false,
"args": [
{
"name": "if",
Expand All @@ -1091,13 +1109,19 @@
"deprecationReason": null
}
],
"locations": [
"FIELD",
"FRAGMENT_SPREAD",
"INLINE_FRAGMENT"
],
"onOperation": false,
"onFragment": true,
"onField": true
},
{
"name": "include",
"description": "Directs the executor to include this field or fragment only when the `if` argument is true.",
"isRepeatable": false,
"args": [
{
"name": "if",
Expand All @@ -1116,13 +1140,19 @@
"deprecationReason": null
}
],
"locations": [
"FIELD",
"FRAGMENT_SPREAD",
"INLINE_FRAGMENT"
],
"onOperation": false,
"onFragment": true,
"onField": true
},
{
"name": "deprecated",
"description": "The @deprecated directive is used within the type system definition language to indicate deprecated portions of a GraphQL service’s schema,such as deprecated fields on a type or deprecated enum values.",
"isRepeatable": false,
"args": [
{
"name": "reason",
Expand All @@ -1137,6 +1167,12 @@
"deprecationReason": null
}
],
"locations": [
"FIELD_DEFINITION",
"ARGUMENT_DEFINITION",
"ENUM_VALUE",
"INPUT_FIELD_DEFINITION"
],
"onOperation": false,
"onFragment": false,
"onField": false
Expand Down
Loading
Loading