Skip to content

Sort nodes alphabetically when generating selection expressions #8551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 4 commits into from
Aug 18, 2025
Merged

Sort nodes alphabetically when generating selection expressions #8551

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2c888a
Sort nodes alphabetically when generating selection expressions
Cyberboss Aug 15, 2025
5bb97aa
Merge branch 'main' into FixExpressionHashDifferences
michaelstaib Aug 18, 2025
01b27d5
Updated Test Snapshots
michaelstaib Aug 18, 2025
4496581
Merge branch 'main' into FixExpressionHashDifferences
michaelstaib Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/HotChocolate/Core/src/Execution.Projections/SelectionExpressionBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ private void CollectTypes(Context context, ISelection selection, TypeContainer p
{
var assignments = ImmutableArray.CreateBuilder<MemberAssignment>();

foreach (var property in parent.Nodes)
// order by property name so expressions evalutate to the same hash regardless of selection order
foreach (var property in parent.Nodes.OrderBy(node => node.Property.Name))
{
var assignment = BuildAssignmentExpression(property, context);
if (assignment is not null)
Expand Down