Skip to content

[Fusion] Add support for result from different subgraph on interfaces - #8293

Merged
michaelstaib merged 4 commits into
ChilliCream:fusion-15-interface-fixfrom
Enterprize1:fix_fusion_on_interfaces
May 23, 2025
Merged

michaelstaib merged 4 commits into
ChilliCream:fusion-15-interface-fixfrom
Enterprize1:fix_fusion_on_interfaces

Conversation

@Enterprize1

@Enterprize1 Enterprize1 commented May 19, 2025 •

Copy link
Copy Markdown
Contributor

Closes #7365.

When requesting a result from a different subgraph on an interface with multiple implementing types the request to the second subgraph was planned multiple times (once for each implementing type). This lead the compose-step to return null for the data from the second subgraph as the data was requested and added multiple times for each object returned by the interface list.

(Hope that explains the problem, if not maybe comparison of the query plan for the test I added before and after the change in ExecutionStepDiscoveryMiddleware.cs could provide some clarification :) )

Now only a single request to the second subgraph is planned for all types implementing the interface by deduplicating the contents of the backlog during execution step discovery.

@Enterprize1

Copy link
Copy Markdown
Contributor Author

The failed checks seem unrelated to me, the Fusion.CommandLine test failed before on the main-version-15 branch.

@tobias-tengler

Copy link
Copy Markdown
Member

Thank you for the contribution 😊
Funnily enough we had the same problem at my company and I started to write some tests for the issue in #8272.
With your fix applied all the problematic tests there seem to pass 🎉

@michaelstaib
michaelstaib changed the base branch from main-version-15 to fusion-15-interface-fix May 23, 2025 12:11
@michaelstaib
michaelstaib merged commit 8607cec into ChilliCream:fusion-15-interface-fix May 23, 2025
@michaelstaib michaelstaib added this to the HC-15.1.6 milestone May 23, 2025
@PascalSenn

Copy link
Copy Markdown
Member

Thanks you for the contribution, @Enterprize1! 🚀

Preview version 15.1.6-p.1 should be available on NuGet in about 15–20 minutes.

If you haven’t already, feel free to join our Slack community and say hello! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants