Skip to content

Disabled FS3261 - #7501

Merged
michaelstaib merged 2 commits into
mainfrom
gai/disable-FS3261
Sep 24, 2024
Merged

michaelstaib merged 2 commits into
mainfrom
gai/disable-FS3261

Conversation

@glen-84

@glen-84 glen-84 commented Sep 24, 2024

Copy link
Copy Markdown
Member

Summary of the changes (Less than 80 chars)

  • Disabled FS3261.

@codecov

codecov Bot commented Sep 24, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (688e71f) to head (16b993f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7501      +/-   ##
==========================================
+ Coverage   77.86%   77.88%   +0.01%     
==========================================
  Files        2826     2826              
  Lines      141958   141958              
==========================================
+ Hits       110541   110561      +20     
+ Misses      31417    31397      -20     
Flag Coverage Δ
unittests 77.88% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib
michaelstaib merged commit 8444c21 into main Sep 24, 2024
@michaelstaib
michaelstaib deleted the gai/disable-FS3261 branch September 24, 2024 12:54
michaelstaib pushed a commit that referenced this pull request Sep 24, 2024
@glen-84

glen-84 commented Sep 24, 2024

Copy link
Copy Markdown
Member Author

@cmeeren If you're interested in helping to fix these nullness warnings, we would welcome a PR. 🙂

@cmeeren

cmeeren commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

Given #7472 (comment) and #7472 (comment) it's possible this is not relevant much longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants