Repository navigation
Used CookieCrumble in more test projects - #7461
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7461 +/- ##
==========================================
- Coverage 77.86% 77.86% -0.01%
==========================================
Files 2826 2826
Lines 141958 141958
==========================================
- Hits 110541 110530 -11
- Misses 31417 31428 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michaelstaib
marked this pull request as ready for review
September 24, 2024 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
@michaelstaib @PascalSenn – There are two remaining test projects using Snapshooter:
CodeGeneration.CSharp.TestsCodeGeneration.Razor.TestsRemoving the
Snapshot.FullName();usage here is difficult, as the test helpers do some funky stuff with paths.Could you please assist with this? It's currently not possible to set a custom path for the snapshot. TBH, the snapshots should probably not be written to
.csfiles outside of a snapshot directory (as it adds to compilation overhead).Notes:
__mismatch__is now used everywhere (instead of a mix of that and__MISMATCH__).TryTeststuff fromRedisOperationDocumentStorageTests. I'm not sure what purpose it served, and 2 of the tests relied onSnapshot.FullName();because of it.