Repository navigation
Included tag directive in Apollo Federation import list - #7421
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7421 +/- ##
=======================================
Coverage 77.95% 77.95%
=======================================
Files 2836 2836
Lines 142551 142562 +11
=======================================
+ Hits 111129 111139 +10
- Misses 31422 31423 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michaelstaib
self-requested a review
September 24, 2024 09:57
michaelstaib
marked this pull request as ready for review
September 29, 2024 20:40
michaelstaib
pushed a commit
that referenced
this pull request
Sep 30, 2024
(cherry picked from commit d8b055a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Closes #7413
@michaelstaib This is roughly what we discussed, but it's probably not correct, since I assume that it should only be included when the tag directive is used in the schema? If so, is there an easy way to check that?