Skip to content

Trailing commas in editorconfig - #6768

Merged
michaelstaib merged 6 commits into
mainfrom
anton/editorconfig
Dec 13, 2023
Merged

michaelstaib merged 6 commits into
mainfrom
anton/editorconfig

Conversation

@AntonC9018

Copy link
Copy Markdown
Contributor
  • Enforce trailing commas in lists;
  • Add trailing commas in some of the projects.

Now, I think naming conventions can't be properly configured in a generic way.
Rider would simply ignore them.

There are Rider settings, but they are:

  • Rider-specific,
  • per-solution,
  • are currently ignored in the repo.

So I'll refrain from further action on this for now.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov

codecov Bot commented Dec 13, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (3ed4025) 63.92% compared to head (6831d9e) 63.92%.
Report is 1 commits behind head on main.

Files Patch % Lines
...Types/Resolvers/DirectiveClassMiddlewareFactory.cs 0.00% 5 Missing ⚠️
.../Types/Extensions/DirectiveCollectionExtensions.cs 0.00% 5 Missing ⚠️
...pes.Mutations/MutationConventionTypeInterceptor.cs 0.00% 4 Missing ⚠️
...src/Types.Mutations/Errors/ErrorFactoryCompiler.cs 0.00% 3 Missing ⚠️
src/HotChocolate/Core/src/Abstractions/Path.cs 0.00% 2 Missing ⚠️
src/HotChocolate/Core/src/Execution/ErrorHelper.cs 50.00% 2 Missing ⚠️
.../Execution/Pipeline/OperationResolverMiddleware.cs 60.00% 2 Missing ⚠️
...xecution/Pipeline/WritePersistedQueryMiddleware.cs 0.00% 2 Missing ⚠️
...colate/Core/src/Execution/Processing/PathHelper.cs 50.00% 2 Missing ⚠️
.../Core/src/Types/Types/Extensions/TypeExtensions.cs 0.00% 2 Missing ⚠️
... and 40 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6768   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files        2324     2324           
  Lines      114629   114629           
=======================================
+ Hits        73275    73277    +2     
+ Misses      41354    41352    -2     
Flag Coverage Δ
unittests 63.92% <56.02%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

Copy link
Copy Markdown
Contributor

Qodana for .NET

376 new problems were found

Inspection name Severity Problems
Use preferred style for trailing comma before new line in multiline lists 🔴 Failure 330
Unused parameter (private accessibility) 🔶 Warning 23
Type member is never used (private accessibility) 🔶 Warning 20
Redundant using directive 🔶 Warning 3

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants