Avoid checking for null on non-nullable property for projection

[glen-84]

Summary of the changes (Less than 80 chars)

• Check the nullability of properties before doing a null check.

Closes #6604.

[glen-84]

@PascalSenn Is this feasible?

[PascalSenn]

@glen-84

We did remove it once for ef core and then added it again:
#6604 (comment)

So i am not sure what to do now. I believe if you do not do the nullcheck then it will include all the fields from the child or something like this.

[glen-84]

You removed it completely, or conditionally based on the nullability of the property?

Should I be seeing something significant in the test snapshots, or is there no test that would highlight the previous issue? If not, then I think that we need that test to exist in order to have some more confidence here.

[PascalSenn]

This is the context:
28ed6ae

So you only apply it when the property is nullable and ef does not complain?

[glen-84]

So you only apply it when the property is nullable and ef does not complain?

By "does not complain", you mean that the tests in HotChocolate.Data.Projections.SqlServer.Tests pass? If so, yes, they all pass.

[glen-84]

This will quite likely fix these issues as well:

• Projection cause "Index out of range" on Database first EF core (net 6)  #5229
• Owned entity returning null if any property is null in net7 #5542

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (6a3b7a3) to head (2a5d875).
Report is 79 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #6706       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This pull request fixes issue #6604 where the projection middleware was generating null checks for non-nullable properties, causing EF Core 8 to throw an InvalidOperationException when comparing complex types to null. The fix adds nullability checking using NullabilityInfoContext to determine whether a property is nullable before adding the null check condition in the generated expression.

Changes:

• Modified QueryableProjectionFieldHandler to check property nullability before generating null checks
• Added a new test file QueryableProjectionComplexTypeTests.cs to verify complex type projections work without inappropriate null checks
• Updated 42 test snapshots showing removal of unnecessary constant expressions (like 1 and 1 AS "c") from generated SQL queries

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 3 comments.

File	Description
src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionFieldHandler.cs	Added static NullabilityInfoContext instance and nullability check before adding null check expression
src/HotChocolate/Data/test/Data.Projections.SqlServer.Tests/QueryableProjectionComplexTypeTests.cs	New test file verifying that complex types project correctly without null checks
src/HotChocolate/Data/test/Data.Projections.SqlServer.Tests/snapshots/*.snap	Updated 42 snapshot files reflecting removal of unnecessary constant expressions in SQL

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.