Skip to content

Fixes documentation of dynamic topics - #6664

Merged
michaelstaib merged 1 commit into
ChilliCream:mainfrom
aokellermann:aokellermann/6111
Nov 3, 2023
Merged

michaelstaib merged 1 commit into
ChilliCream:mainfrom
aokellermann:aokellermann/6111

Conversation

@aokellermann

Copy link
Copy Markdown
Contributor

Fixes outdated documentation on how to use dynamic topics (breaking change in v13).

Closes #6111

@CLAassistant

CLAassistant commented Nov 3, 2023 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the 📚 documentation This issue is about working on our documentation. label Nov 3, 2023
@codecov

codecov Bot commented Nov 3, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6965960) 78.98% compared to head (d49d94d) 78.15%.
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6664      +/-   ##
==========================================
- Coverage   78.98%   78.15%   -0.84%     
==========================================
  Files        2903     2541     -362     
  Lines      139771   127082   -12689     
==========================================
- Hits       110397    99318   -11079     
+ Misses      29374    27764    -1610     
Flag Coverage Δ
unittests 78.15% <82.05%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/src/CookieCrumble/Extensions/WriterExtensions.cs 100.00% <ø> (ø)
...CookieCrumble/src/CookieCrumble/TestEnvironment.cs 0.00% <ø> (ø)
...polloFederationRequestExecutorBuilderExtensions.cs 66.66% <100.00%> (ø)
...ensions/ApolloFederationSchemaBuilderExtensions.cs 86.66% <ø> (ø)
.../src/ApolloFederation/FederationTypeInterceptor.cs 100.00% <100.00%> (ø)
...ion/src/ApolloFederation/Helpers/ArgumentParser.cs 68.65% <100.00%> (+0.47%) ⬆️
...rc/AspNetCore.CommandLine/Command/ExportCommand.cs 100.00% <100.00%> (ø)
...tChocolateAspNetCoreServiceCollectionExtensions.cs 93.33% <ø> (+26.66%) ⬆️
...rc/AspNetCore/Extensions/HttpResponseExtensions.cs 26.31% <ø> (+4.57%) ⬆️
...pNetCore/src/AspNetCore/GraphQLRequestException.cs 25.00% <ø> (+5.00%) ⬆️
... and 13 more

... and 877 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib
michaelstaib merged commit bb94456 into ChilliCream:main Nov 3, 2023
@aokellermann
aokellermann deleted the aokellermann/6111 branch November 3, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation This issue is about working on our documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribute 'Topic' is not valid on this declaration type. It is valid on 'Method' declarations only.

4 participants