Skip to content

Remove obsolete APIs - #6657

Merged
michaelstaib merged 3 commits into
mainfrom
tte/remove-obsolete-apis
Nov 2, 2023
Merged

michaelstaib merged 3 commits into
mainfrom
tte/remove-obsolete-apis

Conversation

@tobias-tengler

@tobias-tengler tobias-tengler commented Nov 1, 2023 •

Copy link
Copy Markdown
Member

Removes APIs that were marked as obsolete in <= v12.

@codecov

codecov Bot commented Nov 1, 2023 •

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6965960) 78.98% compared to head (117faa7) 78.50%.
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6657      +/-   ##
==========================================
- Coverage   78.98%   78.50%   -0.49%     
==========================================
  Files        2903     2556     -347     
  Lines      139771   127989   -11782     
==========================================
- Hits       110397   100474    -9923     
+ Misses      29374    27515    -1859     
Flag Coverage Δ
unittests 78.50% <94.44%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/src/CookieCrumble/Extensions/WriterExtensions.cs 100.00% <ø> (ø)
...CookieCrumble/src/CookieCrumble/TestEnvironment.cs 0.00% <ø> (ø)
...polloFederationRequestExecutorBuilderExtensions.cs 66.66% <100.00%> (ø)
...ensions/ApolloFederationSchemaBuilderExtensions.cs 86.66% <ø> (ø)
.../src/ApolloFederation/FederationTypeInterceptor.cs 100.00% <100.00%> (ø)
...ion/src/ApolloFederation/Helpers/ArgumentParser.cs 68.65% <100.00%> (+0.47%) ⬆️
...rc/AspNetCore.CommandLine/Command/ExportCommand.cs 100.00% <100.00%> (ø)
...tChocolateAspNetCoreServiceCollectionExtensions.cs 66.66% <ø> (ø)
...rc/AspNetCore/Extensions/HttpResponseExtensions.cs 26.31% <ø> (+4.57%) ⬆️
...olate/AspNetCore/src/AspNetCore/HeaderUtilities.cs 84.04% <ø> (+3.19%) ⬆️
... and 10 more

... and 667 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobias-tengler
tobias-tengler force-pushed the tte/remove-obsolete-apis branch 2 times, most recently from a8a932c to b6fecde Compare November 1, 2023 20:13
@michaelstaib

Copy link
Copy Markdown
Member

Thank you tobias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants