Skip to content

Fix sse message corruption - #6642

Merged
michaelstaib merged 6 commits into
ChilliCream:mainfrom
sunghwan2789:fix/sse-invalid-message
Nov 10, 2023
Merged

michaelstaib merged 6 commits into
ChilliCream:mainfrom
sunghwan2789:fix/sse-invalid-message

Conversation

@sunghwan2789

@sunghwan2789 sunghwan2789 commented Oct 29, 2023 •

Copy link
Copy Markdown
Contributor

and possible memory leak?

@sunghwan2789
sunghwan2789 force-pushed the fix/sse-invalid-message branch from cde10a4 to 057b9be Compare October 29, 2023 12:33
@michaelstaib
michaelstaib self-requested a review October 31, 2023 17:21
@michaelstaib michaelstaib added this to the HC-13.7.0 milestone Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@codecov

codecov Bot commented Oct 31, 2023 •

Copy link
Copy Markdown

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6965960) 78.98% compared to head (aadcb0f) 77.01%.
Report is 71 commits behind head on main.

❗ Current head aadcb0f differs from pull request most recent head 7eda114. Consider uploading reports for the commit 7eda114 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6642      +/-   ##
==========================================
- Coverage   78.98%   77.01%   -1.98%     
==========================================
  Files        2903     2936      +33     
  Lines      139771   141730    +1959     
==========================================
- Hits       110397   109150    -1247     
- Misses      29374    32580    +3206     
Flag Coverage Δ
unittests 77.01% <89.28%> (-1.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/src/CookieCrumble/Extensions/WriterExtensions.cs 100.00% <ø> (ø)
...CookieCrumble/src/CookieCrumble/TestEnvironment.cs 0.00% <ø> (ø)
...polloFederationRequestExecutorBuilderExtensions.cs 66.66% <100.00%> (ø)
...ensions/ApolloFederationSchemaBuilderExtensions.cs 86.66% <ø> (ø)
.../src/ApolloFederation/FederationTypeInterceptor.cs 100.00% <100.00%> (ø)
...ion/src/ApolloFederation/Helpers/ArgumentParser.cs 68.65% <100.00%> (+0.47%) ⬆️
...rc/AspNetCore.CommandLine/Command/ExportCommand.cs 100.00% <100.00%> (ø)
...rc/AspNetCore/Extensions/HttpResponseExtensions.cs 26.31% <ø> (+4.57%) ⬆️
...olate/AspNetCore/src/AspNetCore/HeaderUtilities.cs 80.85% <ø> (ø)
...ate/AspNetCore/src/AspNetCore/HttpGetMiddleware.cs 82.31% <ø> (ø)
... and 99 more

... and 248 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@ChilliCream ChilliCream deleted a comment from github-actions Bot Oct 31, 2023
@michaelstaib michaelstaib removed this from the HC-13.7.0 milestone Nov 1, 2023
@michaelstaib

Copy link
Copy Markdown
Member

Thank you for your help on Hot Chocolate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants