Repository navigation
Fix parent requirements being dropped from paged projections - #10701
Merged
Merged
Conversation
Contributor
Patch coverage100.0% of changed lines covered (1/1)
Project coverage: 59.4% (317091/533687 lines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a field uses
[Parent(requires: ...)]on a list with[UsePaging]or[UseOffsetPaging]and[UseProjection], the required property was not loaded, so the resolver saw a default value. Paging builds the database query from a hidden internal field, and since #9978 every field below it is internal too. The requirements optimizer skipped all internal fields, so it never saw the fields the client selected. It now only skips the hidden requirement fields it adds itself.{ items { nodes { nameLength } } }For an item named
abc,nameLengthwas0before this fix and is3now.