Repository navigation
Pin Ubuntu runners to ubuntu-26.04 - #10667
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified, and the reviewed changes consistently implement the stated runner pinning and compatibility goals.
No open issues 🎉
What changed in this PR
This pull request pins GitHub Actions workflows to Ubuntu 26.04 for predictable runner images while retaining Ubuntu 22.04 for Nitro CLI builds requiring the older glibc baseline.
Changes:
- Replaces
ubuntu-latestwithubuntu-26.04across CI, release, publishing, labeling, benchmarking, coverage, and maintenance workflows. - Preserves Ubuntu 22.04 runners for portable Nitro CLI Linux builds and documents the compatibility rationale.
- Adds actionlint configuration for the currently unrecognized
ubuntu-26.04label. - Updates related workflow documentation, comments, and spelling data.
| File | Description |
|---|---|
website/playwright.config.ts |
Updates the visual-test rendering environment comment. |
src/HotChocolate/CostAnalysis/tools/oracle/README.md |
Documents the pinned nightly workflow runner. |
dictionary.txt |
Adds rhysd for spell checking. |
.github/workflows/release.yml |
Pins release jobs while preserving Ubuntu 22.04 for glibc-based CLI builds. |
.github/workflows/publish-website.yml |
Pins the website publishing runner. |
.github/workflows/pr-labeler.yml |
Pins the pull-request labeling runner. |
.github/workflows/nitro-cli-e2e.yml |
Pins Nitro CLI end-to-end test runners. |
.github/workflows/issue-labeler.yml |
Pins the issue labeling runner. |
.github/workflows/coverage.yml |
Pins coverage workflow runners. |
.github/workflows/cost-oracle-nightly.yml |
Pins nightly cost-analysis runners and updates its compiler comment. |
.github/workflows/ci.yml |
Pins the main CI workflow runners. |
.github/workflows/ci-cleanup.yml |
Pins the CI cleanup runner. |
.github/workflows/benchmarks.yml |
Pins benchmark setup and reporting runners. |
.github/actionlint.yaml |
Suppresses the expected unknown-label diagnostic for ubuntu-26.04. |
Review effort: Lite
Contributor
|
✅ Nitro CLI E2E snapshots: no flow recordings changed vs |
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-latestjob toubuntu-26.04, so the runner image changes only through an explicit edit, and jobs no longer carry the notice aboutubuntu-latestmoving to Ubuntu 26.04 ([Ubuntu]ubuntu-latestlabel will use Ubuntu 26.04 in November 2026 actions/runner-images#14748).linux-x64andlinux-arm64release builds stay onubuntu-22.04andubuntu-22.04-arm. A comment inrelease.ymlnow records why: the binary runs only on systems with the build host's glibc or newer, so these builds use the oldest supported LTS..github/actionlint.yaml, which ignores actionlint's unknown-label error forubuntu-26.04. actionlint 1.7.12, the latest release, does not know the label yet (Add support forubuntu-26.04rhysd/actionlint#682).Test plan
main: only the existing shellcheck info notes.ci.ymljobs ran on Ubuntu 24.04 underubuntu-latest, so this PR's CI is their first run on Ubuntu 26.04. Playwright 1.62.1 supports Ubuntu 26.04 forinstall --with-deps. The website visual tests are the most likely to be affected by font rendering.