Skip to content

[Fusion] Reuse completed object types in Apollo representations - #10589

Merged
tobias-tengler merged 1 commit into
mainfrom
tte/reuse-representation-runtime-types
Oct 18, 2026
Merged

tobias-tengler merged 1 commit into
mainfrom
tte/reuse-representation-runtime-types

Conversation

@tobias-tengler

@tobias-tengler tobias-tengler commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Apollo representations decode __typename and resolve its schema type even when the completed object already carries its concrete type.

This PR reuses the existing type and name when the actual type name matches the completed object’s concrete selection type. Missing, escaped and opaque type handling and the imported-snapshot fallback retain their contracts.

Method Version Mean Ratio Allocated Alloc Ratio
Concrete representations, 16 objects main 4.806 us 1.00 1272 B 1.00
Concrete representations, 16 objects PR 4.553 us 0.95 1272 B 1.00
Mixed abstract representations, 16 objects main 14.976 us 1.00 1784.5 B 1.00
Mixed abstract representations, 16 objects PR 13.837 us 0.92 1272 B 0.71
Nested abstract representations, 16 objects main 14.643 us 1.00 1785 B 1.00
Nested abstract representations, 16 objects PR 13.706 us 0.94 1272 B 0.71
Imported snapshot representations, 16 objects main 3.064 us 1.00 1032 B 1.00
Imported snapshot representations, 16 objects PR 2.935 us 0.96 1032 B 1.00

@github-actions

Copy link
Copy Markdown
Contributor

Patch coverage

100.0% of changed lines covered (10/10)

File Covered Changed Patch %
…/Execution/Results/FetchResultStore.RepresentationValue.cs 10 10 100.0% 🟢

Project coverage: 59.0% (311511/527765 lines)

@tobias-tengler
tobias-tengler marked this pull request as ready for review October 18, 2026 05:56
Copilot AI balanced review requested due to automatic review settings October 18, 2026 05:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants