Repository navigation
[Fusion] Fix Apollo result cleanup when execution is canceled - #10580
Merged
Merged
Conversation
Contributor
Patch coverage100.0% of changed lines covered (1/1)
Project coverage: 59.0% (311292/527641 lines) |
glen-84
pushed a commit
that referenced
this pull request
Oct 19, 2026
This was referenced Oct 20, 2026
Merged
Merged
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Apollo entity source can yield its result and then cancel the final asynchronous stream read. Before merge ownership transfers, the Apollo execution node's cancellation catch returns without disposing its retained result.
This PR disposes that result before the existing cancellation return, matching the neighboring failure cleanup. Cancellation status, diagnostics and successful transfer paths stay unchanged.