Skip to content

[Fusion] Fix repeated selection resolution in object list completion - #10560

Merged
tobias-tengler merged 2 commits into
mainfrom
perf/fusion-list-completion-20261016
Oct 18, 2026
Merged

tobias-tengler merged 2 commits into
mainfrom
perf/fusion-list-completion-20261016

Conversation

@tobias-tengler

@tobias-tengler tobias-tengler commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Fusion resolves the same concrete object type and invokes the cached child-selection resolver for each object in a homogeneous list.

This PR keeps the concrete type and lazily resolved selection set at list scope, then passes the prepared set directly to object completion.

Benchmarks

Case Version Median Ratio Allocated Alloc Ratio
1,000 rows main 114.407 µs 1.00 472 B 1.00
1,000 rows PR 86.527 µs 0.76 472 B 1.00
20,000 rows main 2,218.957 µs 1.00 1,656 B 1.00
20,000 rows PR 1,688.506 µs 0.76 1,656 B 1.00

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Patch coverage

100.0% of changed lines covered (16/16)

File Covered Changed Patch %
…/src/Fusion.Execution/Execution/Results/ValueCompletion.cs 16 16 100.0% 🟢

Project coverage: 59.0% (311588/527854 lines)

@tobias-tengler
tobias-tengler marked this pull request as ready for review October 18, 2026 08:59
Copilot AI balanced review requested due to automatic review settings October 18, 2026 08:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants