Skip to content

[Mocha] Fix PostgreSQL outbox persistence connection lifetime #10478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PascalSenn merged 3 commits into from
Oct 4, 2026
Merged

[Mocha] Fix PostgreSQL outbox persistence connection lifetime #10478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3977e40
Fix PostgreSQL outbox persistence connection lifetime
tobias-tengler Oct 4, 2026
3caf522
Simplify PostgreSQL outbox regression assertions
tobias-tengler Oct 4, 2026
6b3031f
Simplify PostgreSQL outbox connection lifetime test setup
tobias-tengler Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions src/Mocha/src/Mocha.EntityFrameworkCore.Postgres/Outbox/PostgresMessageOutbox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,28 +78,32 @@ public async ValueTask PersistAsync(MessageEnvelope envelope, CancellationToken

var connection = (NpgsqlConnection)_originalDbContext.Database.GetDbConnection();

if (connection.State != System.Data.ConnectionState.Open)
try
{
await connection.OpenAsync(cancellationToken);
}
await _originalDbContext.Database.OpenConnectionAsync(cancellationToken);

await using var writer = new Utf8JsonWriter(_arrayWriter);
writer.WriteEnvelope(envelope);
writer.Flush(); // we know it's not async
await using var writer = new Utf8JsonWriter(_arrayWriter);
writer.WriteEnvelope(envelope);
writer.Flush(); // we know it's not async

// Execute the INSERT command
await using var command = connection.CreateCommand();
command.CommandText = _insertSql;
command.Parameters.AddWithValue("@id", NewVersion());
command.Parameters.Add(
new NpgsqlParameter("@envelope", NpgsqlDbType.Json) { Value = _arrayWriter.WrittenMemory });
await command.PrepareAsync(cancellationToken);
// Execute the INSERT command
await using var command = connection.CreateCommand();
command.CommandText = _insertSql;
command.Parameters.AddWithValue("@id", NewVersion());
command.Parameters.Add(
new NpgsqlParameter("@envelope", NpgsqlDbType.Json) { Value = _arrayWriter.WrittenMemory });
await command.PrepareAsync(cancellationToken);

await command.ExecuteNonQueryAsync(cancellationToken);
await command.ExecuteNonQueryAsync(cancellationToken);

if (_originalDbContext.Database.CurrentTransaction?.GetDbTransaction() is not NpgsqlTransaction)
if (_originalDbContext.Database.CurrentTransaction?.GetDbTransaction() is not NpgsqlTransaction)
{
_signal.Set();
}
}
finally
{
_signal.Set();
await _originalDbContext.Database.CloseConnectionAsync();
}
}
finally
Expand Down
6 changes: 6 additions & 0 deletions .../Mocha.EntityFrameworkCore.Postgres.Tests/Mocha.EntityFrameworkCore.Postgres.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
<ProjectReference Include="..\..\src\Mocha\Mocha.csproj" />
<ProjectReference Include="..\..\src\Mocha.Outbox\Mocha.Outbox.csproj" />
<ProjectReference Include="..\..\src\Mocha.Inbox\Mocha.Inbox.csproj" />
<ProjectReference Include="..\..\..\CookieCrumble\src\CookieCrumble\CookieCrumble.csproj" />
<ProjectReference Include="..\..\..\CookieCrumble\src\CookieCrumble.Xunit3\CookieCrumble.Xunit3.csproj" />
<ProjectReference
Include="..\..\..\CookieCrumble\src\CookieCrumble.Analyzers\CookieCrumble.Analyzers.csproj"
OutputItemType="Analyzer"
/>
<ProjectReference Include="..\..\..\CookieCrumble\src\CookieCrumble.Resources.PostgreSql\CookieCrumble.Resources.PostgreSql.csproj" />
</ItemGroup>
</Project>
Loading
Loading