Repository navigation
Update vulnerable npm packages and gate SpecVersion test installs - #10456
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Correct min-release-age from 7 minutes to 10080 minutes.
Review effort: Lite
Findings: None
What changed in this PR
Updates vulnerable npm dependencies and adds an npm release-age gate for SpecVersion test installs.
Changes:
- Upgrades
brace-expansionandundiciinwebsite/yarn.lock. - Adds
.npmrcfor npm release-age protection.
| File | Summary |
|---|---|
website/yarn.lock |
Updates vulnerable dependency resolutions and checksums. |
src/HotChocolate/Core/test/Types.SpecVersion.Tests/node/.npmrc |
Adds the release-age gate; min-release-age should be 10080 for seven days. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brace-expansionin the website lockfile from 1.1.18 and 5.0.9 to 1.1.21 and 5.0.12, clearing GHSA-6j4f-fj2g-mc7p, GHSA-qhr7-859c-m2p7, and GHSA-q2hr-2g5m-vwhr. It is reached throughminimatchin ESLint and the Storybook build.undicithatnode-gyppulls in from 6.28.0 to 6.28.1, clearing GHSA-rfgv-xxqx-mfg5, GHSA-3wwx-pv8p-q78v, and GHSA-r53p-7pc4-xj5r. Both moves stay inside the parents' declared ranges, so no manifest changes..npmrcwithmin-release-age=7to theTypes.SpecVersion.Testsnode root, the only npm root without a minimum release age. The yarn roots already setnpmMinimalAgeGate.Test plan
yarn npm audit --all --recursiveinwebsite/reports no advisories, in both the full and the--environment productionview.yarn tsc --noEmit,yarn lint,yarn build, and the Storybook build pass inwebsite/.Types.SpecVersion.Testsnode root,npm config listshows the gate applied, andnpm install --dry-runstill resolves both pinnedgraphqlaliases.