Repository navigation
Fix schema reloads disposing application services - #10450
Merged
Merged
Conversation
tobias-tengler
force-pushed
the
fix/mcp-root-logger-factory-disposal
branch
from
September 29, 2026 14:10
21c4ca5 to
44e65dc
Compare
tobias-tengler
marked this pull request as ready for review
September 29, 2026 14:18
Contributor
Patch coverage100.0% of changed lines covered (16/16)
Project coverage: 57.8% (299149/517913 lines) |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The ownership corrections are consistent and covered by targeted disposal regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents schema executor disposal during reloads from disposing application-owned singleton services.
Changes:
- Registers shared caches, error filters, logging, and host lifetime services as non-owned instances.
- Adds Core, Fusion, and MCP disposal regression tests.
- Adds a reusable disposal probe for MCP tests.
| File | Description |
|---|---|
FusionDocumentCacheTests.cs |
Tests Fusion cache ownership. |
ErrorFilterTests.cs |
Tests Fusion error-filter ownership. |
HotChocolateFusionServiceCollectionExtensions.cs |
Prevents schema ownership of document caches. |
CoreFusionGatewayBuilderExtensions.ErrorFilter.cs |
Prevents schema ownership of error filters. |
DocumentCacheTests.cs |
Tests Core cache ownership. |
RequestExecutorBuilderExtensions.Caches.cs |
Corrects Core cache registration ownership. |
FusionIntegrationTests.cs |
Tests MCP behavior across Fusion reloads. |
DisposalProbe.cs |
Signals schema-service disposal in tests. |
CoreIntegrationTests.cs |
Tests MCP behavior across Core eviction. |
ServiceCollectionExtensions.cs |
Forwards root host services without transferring ownership. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tobias-tengler
force-pushed
the
fix/mcp-root-logger-factory-disposal
branch
from
September 29, 2026 14:24
44e65dc to
5dbc2d7
Compare
glen-84
pushed a commit
that referenced
this pull request
Oct 8, 2026
This was referenced Oct 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.