Skip to content

[Nitro CLI] Use the dedicated Fusion validation flow in fusion validate - #10446

Merged
tobias-tengler merged 3 commits into
tte/expand-cli-source-metadatafrom
tte/dedicated-fusion-validate-flow
Sep 29, 2026
Merged

tobias-tengler merged 3 commits into
tte/expand-cli-source-metadatafrom
tte/dedicated-fusion-validate-flow

Conversation

@tobias-tengler

@tobias-tengler tobias-tengler commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the 📚 documentation This issue is about working on our documentation. label Sep 29, 2026
Copilot AI balanced review requested due to automatic review settings September 29, 2026 07:33
@tobias-tengler
tobias-tengler force-pushed the tte/dedicated-fusion-validate-flow branch from 2dae8ff to 8efb88b Compare September 29, 2026 07:33
@github-actions

Copy link
Copy Markdown
Contributor

✅ Nitro CLI E2E snapshots: no flow recordings changed vs tte/expand-cli-source-metadata.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Timeout validation errors are neither fully selected nor rendered, resulting in empty failure details.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Updates fusion validate to use Nitro’s dedicated Fusion validation mutation and subscription instead of schema validation.

Changes:

  • Adds dedicated Fusion validation client operations.
  • Updates CLI execution, error rendering, and tests.
  • Documents availability from Nitro 10.6.0.
File Description
website/​content/​docs/​nitro/​cli/​fusion.md Adds the minimum Nitro version.
src/​Nitro/​Common/​src/​ChilliCream.Nitro.Client/​schema.graphql Adds the validation API contract.
src/​Nitro/​Common/​src/​ChilliCream.Nitro.Client/​persisted/​operations.json Registers the new persisted operations.
src/​Nitro/​Common/​src/​ChilliCream.Nitro.Client/​FusionConfiguration/​Operations/​FusionValidateCommand.graphql Defines validation mutation and subscription.
src/​Nitro/​Common/​src/​ChilliCream.Nitro.Client/​FusionConfiguration/​IFusionConfigurationClient.cs Exposes validation client methods.
src/​Nitro/​Common/​src/​ChilliCream.Nitro.Client/​FusionConfiguration/​FusionConfigurationClient.cs Implements validation requests and updates.
src/​Nitro/​CommandLine/​test/​CommandLine.Tests/​Commands/​MockErrorFactory.cs Updates generated validation interfaces.
src/​Nitro/​CommandLine/​test/​CommandLine.Tests/​Commands/​Fusion/​FusionValidateCommandTests.cs Migrates command tests to the dedicated flow.
src/​Nitro/​CommandLine/​test/​CommandLine.Tests/​Commands/​Fusion/​FusionConfigurationPublishValidateCommandTests.cs Updates validation error mocks.
src/​Nitro/​CommandLine/​test/​CommandLine.Tests/​Commands/​Fusion/​FusionCommandTestBase.cs Adds validation test helpers and events.
src/​Nitro/​CommandLine/​src/​CommandLine/​Extensions/​TreeNodeExtensions.cs Centralizes Fusion validation error rendering.
src/​Nitro/​CommandLine/​src/​CommandLine/​Commands/​Fusion/​FusionValidateCommand.cs Switches the command to the dedicated flow.
src/​Nitro/​CommandLine/​src/​CommandLine/​Commands/​Fusion/​FusionPublishHelpers.cs Reuses centralized error rendering.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tobias-tengler
tobias-tengler force-pushed the tte/dedicated-fusion-validate-flow branch from 8efb88b to 7c1e18e Compare September 29, 2026 07:45
@tobias-tengler
tobias-tengler force-pushed the tte/dedicated-fusion-validate-flow branch from 19ddec9 to 3627285 Compare September 29, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation This issue is about working on our documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants