Skip to content

Fix input path leaking into the error path during variable coercion - #10406

Merged
michaelstaib merged 4 commits into
mainfrom
mst/error-shape-fix
Sep 18, 2026
Merged

Fix input path leaking into the error path during variable coercion#10406
michaelstaib merged 4 commits into
mainfrom
mst/error-shape-fix

Conversation

@michaelstaib

@michaelstaib michaelstaib commented Sep 18, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings September 18, 2026 11:30
Copilot AI reviewed Sep 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Three moderate findings remain regarding preservation of field and inline coercion error locations.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This pull request updates GraphQL variable-coercion errors to report input paths without leaking them into response paths, with related provider and execution snapshot updates.

Changes:

  • Tracks variable names in default-value coercion paths.
  • Adjusts coercion, filtering, sorting, projection, and diagnostic error metadata.
  • Refreshes affected tests and snapshots across providers.
File summaries
File Review
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNotStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNotEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectStringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectEnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ArrayObjectNestedArraySomeStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ArrayObjectNestedArrayAnyStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorInterfacesTests.Create_InterfaceStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorEnumTests.Create_EnumNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorEnumTests.Create_EnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringNotStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringNotEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_StringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_NullableStringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_NullableStringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_NullableStringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorStringTests.Create_NullableStringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectTests.Create_ObjectStringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectTests.Create_ObjectStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectTests.Create_ObjectShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectTests.Create_ObjectShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectTests.Create_ObjectEnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectTests.Create_ArrayObjectNestedArraySomeStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdNullableLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdNullableGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorObjectIdTests.Create_ObjectIdEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorEnumTests.Create_EnumNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorEnumTests.Create_EnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNullableNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNullableNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNullableLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNullableLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNullableGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNullableGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNotLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNotGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/test/Data.MongoDb.Filters.Tests/__snapshots__/MongoDbFilterVisitorComparableTests.Create_ShortEqual_Expression_DateTime.snap Snapshot update reviewed.
src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbSortOperationHandlerBase.cs Implementation change reviewed.
src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDefaultSortFieldHandler.cs Implementation change reviewed.
src/HotChocolate/MongoDb/src/Data/Filters/Handlers/MongoDbDefaultFieldHandler.cs Implementation change reviewed.
src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListOperationHandlerBase.cs Implementation change reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNotStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNotEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectStringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectEnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ArrayObjectNestedArraySomeStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ArrayObjectNestedArrayAnyStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorInterfacesTests.Create_InterfaceStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorEnumTests.Create_EnumNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorEnumTests.Create_EnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ActivityExecutionDiagnosticListenerTests.VariableCoercion_FailingScalar_RecordsErrorOnCoercionSpan.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNoContains_Expression_NET9_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNoContains_Expression_NET8_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringEqual_Expression_NET8_0_NET9_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringContains_Expression_NET8_0_NET9_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNotStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNotEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNoContains_Expression_NET9_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNoContains_Expression_NET8_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectStringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectEnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ArrayObjectNestedArraySomeStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ArrayObjectNestedArrayAnyStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorListTests.Create_ArrayAnyObjectStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorInterfacesTests.Create_InterfaceStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorExpressionTests.Create_CollectionLengthExpression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorExpressionTests.Create_CollectionLengthExpression_NET8_0_NET9_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorEnumTests.Create_EnumNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorEnumTests.Create_EnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThan_Expression_NET9_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThan_Expression_NET8_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThan_Expression_NET9_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThan_Expression_NET8_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableLowerThan_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotLowerThan_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotIn_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotGreaterThan_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotEqual_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThanOrEquals_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThan_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortIn_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThanOrEquals_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThan_Expression_NET10_0.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStructTests.Create_ObjectShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStructTests.Create_ObjectNull.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNotEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_StringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNotStartsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNotEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringNoContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringEndsWith_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorStringTests.Create_NullableStringContains_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectStringIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectNull.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectEnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ArrayObjectNestedArraySomeStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ArrayObjectNestedArrayAnyStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorListTests.Create_ArrayAnyObjectStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorInterfacesTests.Create_InterfaceStringEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorIdTests.Create_StringIdNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorIdTests.Create_StringIdNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorIdTests.Create_StringIdIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorIdTests.Create_StringIdEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorIdTests.Create_ShortNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorIdTests.Create_ShortNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorIdTests.Create_ShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorIdTests.Create_ShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorExpressionTests.Create_CollectionLengthExpression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorEnumTests.Create_EnumNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorEnumTests.Create_EnumEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNullableGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortNotEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortLowerThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortIn_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThanOrEquals_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortGreaterThan_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/__snapshots__/QueryableFilterVisitorComparableTests.Create_ShortEqual_Expression.snap Snapshot update reviewed.
src/HotChocolate/Data/src/Data/ThrowHelper.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableOperationHandlerBase.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDefaultSortFieldHandler.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSortInterceptor.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFilterInterceptor.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Filters/Expressions/QueryableFilterProvider.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringStartsWithHandler.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringNotStartsWithHandler.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringNotEndsWithHandler.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringNotContainsHandler.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringEndsWithHandler.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringContainsHandler.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDefaultFieldHandler.cs Implementation change reviewed.
src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListOperationHandlerBase.cs Implementation change reviewed.
src/HotChocolate/Core/test/Types.Tests/Types/__snapshots__/OneOfIntegrationTests.B_is_variable_and_var_not_set_Error.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/UpdateUserInput.cs Test fixture reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_WithQueryConventions_ObjectInput.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_ObjectInput.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_NestedVariableInput.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_NestedObjectInput.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_Mutation_ObjectInput.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_Mutation_NestedVariableInput.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_Mutation_NestedObjectInput.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_Mutation_ListOfObjectsInput.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_ListOfObjectsInput.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/Spec/__snapshots__/ArgumentCoercionTests.Pass_In_Null_To_NonNullArgument_With_DefaultValue.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/Integration/Components/__snapshots__/VariableCoercionIntegrationTests.Variable_Not_Provided.snap Snapshot update reviewed.
src/HotChocolate/Core/test/Execution.Tests/__snapshots__/ScalarExecutionErrorTests.InputType_Variable_CannotBeDeserialized.snap Snapshot update reviewed.
src/HotChocolate/Core/src/Types/Execution/Processing/VariableCoercionHelper.cs Implementation change reviewed.
src/HotChocolate/Core/src/Types/Execution/Processing/ValueCompletion.Object.cs Implementation change reviewed.
src/HotChocolate/Core/src/Types/Execution/Processing/ValueCompletion.List.cs Implementation change reviewed.
src/HotChocolate/Core/src/Types/Execution/Processing/ValueCompletion.cs Implementation change reviewed.
src/HotChocolate/Core/src/Types/Execution/Processing/SelectionIncludeCondition.cs Implementation change reviewed.
src/HotChocolate/Core/src/Types/Execution/Processing/MiddlewareContext.Arguments.cs Implementation change reviewed.
src/HotChocolate/Core/src/Types/Execution/Extensions/OperationContextExtensions.cs Implementation change reviewed.
Review details

Suppressed comments (2)

src/HotChocolate/Core/src/Types/Execution/Processing/MiddlewareContext.Arguments.cs:34

  • This catch handles inline argument literals as well as variable-rewritten values. Removing TryAddLocation(syntaxNode) therefore makes inline nested-input coercion errors lose their source location, while TryAddLocation already ignores nodes without a location; distinguish inline syntax from variable-originated input instead of removing the location for every LeafCoercionException.
    src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDefaultFieldHandler.cs:42
  • This change drops the document location for inline filter coercion errors, not just variable coercion. For a query such as where: { bar: { eq: null } }, node.Value is the only source location available, and the updated snapshots now lose locations without adding an equivalent inputPath. Preserve the location for inline literals while omitting it only when the value was produced from a variable.
  • Files reviewed: 300/436 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/HotChocolate/Core/src/Types/Execution/Extensions/OperationContextExtensions.cs
@michaelstaib
Fix CI build error and re-record Fusion variable coercion snapshots
472c175 
Remove an unnecessary using directive that failed IDE0005 in CI, which
is enforced only when CI=true.

Re-record the Fusion variable coercion diagnostics snapshots. The source
schema used to answer with the input path in the error path, which the
gateway filed in its error trie; FindFirstError returned it regardless of
its key, so it surfaced as the response path of the root field. The
source schema now reports the input position in extensions, so the error
is relayed as a root error and the gateway falls back to its generic
error for the unresolved field.
@michaelstaib
Merge branch 'main' into mst/error-shape-fix
56157d5
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Patch coverage

62.1% of changed lines covered (41/66)

File Covered Changed Patch %
…/src/Types/Execution/Processing/SelectionIncludeCondition.cs 0 1 0.0% 🔴
…/Core/src/Types/Execution/Processing/ValueCompletion.List.cs 0 1 0.0% 🔴
src/HotChocolate/Core/src/Types/Execution/ThrowHelper.cs 0 1 0.0% 🔴
…/Handlers/String/QueryableStringContainsHandler.cs 0 1 0.0% 🔴
…/Handlers/String/QueryableStringEndsWithHandler.cs 0 1 0.0% 🔴
…/Handlers/String/QueryableStringNotContainsHandler.cs 0 1 0.0% 🔴
…/Handlers/String/QueryableStringNotEndsWithHandler.cs 0 1 0.0% 🔴
…/Handlers/String/QueryableStringNotStartsWithHandler.cs 0 1 0.0% 🔴
…/Handlers/String/QueryableStringStartsWithHandler.cs 0 1 0.0% 🔴
…/Expressions/Interceptor/QueryableFilterInterceptor.cs 0 1 0.0% 🔴
…/Expressions/Interceptor/QueryableSortInterceptor.cs 0 1 0.0% 🔴
…/Expressions/Handlers/QueryableDefaultSortFieldHandler.cs 0 1 0.0% 🔴
…/Expressions/Handlers/QueryableOperationHandlerBase.cs 0 1 0.0% 🔴
…/Data/src/Data/Sorting/Visitor/SortVisitorBase`2.cs 0 2 0.0% 🔴
…/src/Data/Filters/Handlers/MongoDbDefaultFieldHandler.cs 0 1 0.0% 🔴
…/src/Data/Sorting/Handlers/MongoDbDefaultSortFieldHandler.cs 0 1 0.0% 🔴
…/src/Data/Sorting/Handlers/MongoDbSortOperationHandlerBase.cs 0 1 0.0% 🔴
…/Expressions/Handlers/QueryableSpatialBooleanMethodHandler.cs 0 2 0.0% 🔴
…/Expressions/Handlers/QueryableSpatialMethodHandler.cs 0 2 0.0% 🔴
…/Core/src/Types/Execution/Processing/ValueCompletion.Leaf.cs 1 2 50.0% 🔴

+14 more changed files; see the JSON below for uncovered lines.

Uncovered changed lines (JSON) 
{
  "sha": "8a52dc3328c1ac572483fa2c15b1f19fb781941d",
  "files": [
    { "path": "src/HotChocolate/Core/src/Types/Execution/Processing/SelectionIncludeCondition.cs", "ranges": [[72, 72]] },
    { "path": "src/HotChocolate/Core/src/Types/Execution/Processing/ValueCompletion.List.cs", "ranges": [[151, 151]] },
    { "path": "src/HotChocolate/Core/src/Types/Execution/ThrowHelper.cs", "ranges": [[55, 55]] },
    { "path": "src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringContainsHandler.cs", "ranges": [[27, 27]] },
    { "path": "src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringEndsWithHandler.cs", "ranges": [[26, 26]] },
    { "path": "src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringNotContainsHandler.cs", "ranges": [[26, 26]] },
    { "path": "src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringNotEndsWithHandler.cs", "ranges": [[26, 26]] },
    { "path": "src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringNotStartsWithHandler.cs", "ranges": [[24, 24]] },
    { "path": "src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/String/QueryableStringStartsWithHandler.cs", "ranges": [[26, 26]] },
    { "path": "src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFilterInterceptor.cs", "ranges": [[61, 61]] },
    { "path": "src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSortInterceptor.cs", "ranges": [[49, 49]] },
    { "path": "src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDefaultSortFieldHandler.cs", "ranges": [[28, 28]] },
    { "path": "src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableOperationHandlerBase.cs", "ranges": [[37, 37]] },
    { "path": "src/HotChocolate/Data/src/Data/Sorting/Visitor/SortVisitorBase\u00602.cs", "ranges": [[86, 86], [103, 103]] },
    { "path": "src/HotChocolate/MongoDb/src/Data/Filters/Handlers/MongoDbDefaultFieldHandler.cs", "ranges": [[41, 41]] },
    { "path": "src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDefaultSortFieldHandler.cs", "ranges": [[29, 29]] },
    { "path": "src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbSortOperationHandlerBase.cs", "ranges": [[40, 40]] },
    { "path": "src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialBooleanMethodHandler.cs", "ranges": [[59, 59], [71, 71]] },
    { "path": "src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialMethodHandler.cs", "ranges": [[57, 57], [69, 69]] },
    { "path": "src/HotChocolate/Core/src/Types/Execution/Processing/ValueCompletion.Leaf.cs", "ranges": [[41, 41]] },
    { "path": "src/HotChocolate/Core/src/Types/Execution/Processing/ValueCompletion.cs", "ranges": [[52, 52]] },
    { "path": "src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/Comparable/QueryableComparableOperationHandler.cs", "ranges": [[96, 96]] }
  ]
}

Project coverage: 58.0% (288962/498337 lines)

@michaelstaib
michaelstaib merged commit 8d2e9d9 into main Sep 18, 2026
151 checks passed
@michaelstaib
michaelstaib deleted the mst/error-shape-fix branch September 18, 2026 12:39
This was referenced Oct 25, 2026
Open
Closed
Merged
Merged
Merged
Closed
Closed
Open
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

🌶️ hot chocolate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelstaib