Skip to content

Create the schema export directory when it does not exist #10369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glen-84 merged 1 commit into from
Sep 8, 2026
Merged

Create the schema export directory when it does not exist #10369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/HotChocolate/Core/src/Types/Execution/Internal/SchemaFileExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public static async Task<SchemaFileInfo> Export(

var directory = System.IO.Path.GetDirectoryName(schemaFileName)!;

if (Directory.Exists(directory))
if (directory.Length > 0)
{
Directory.CreateDirectory(directory);
}
Expand Down
24 changes: 22 additions & 2 deletions src/HotChocolate/Core/test/Types.Tests/Execution/Internal/SchemaFileExporterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public async Task Export_Should_DeclareBothBatchingModes_When_NoProviderIsRegist
.AddGraphQL()
.AddQueryType(d => d.Name("Query").Field("foo").Resolve("bar"));
var executor = await GetExecutorAsync(services);
Directory.CreateDirectory(_directory);

// act
var result = await SchemaFileExporter.Export(
Expand Down Expand Up @@ -64,7 +63,6 @@ public async Task Export_Should_DeclareProviderCapabilities_When_ProviderIsRegis
.AddGraphQL()
.AddQueryType(d => d.Name("Query").Field("foo").Resolve("bar"));
var executor = await GetExecutorAsync(services);
Directory.CreateDirectory(_directory);

// act
var result = await SchemaFileExporter.Export(
Expand Down Expand Up @@ -98,6 +96,28 @@ public async Task Export_Should_DeclareProviderCapabilities_When_ProviderIsRegis
""" + "\n");
}

[Fact]
public async Task Export_Should_CreateDirectory_When_DirectoryDoesNotExist()
{
// arrange
var services = new ServiceCollection();
services
.AddGraphQL()
.AddQueryType(d => d.Name("Query").Field("foo").Resolve("bar"));
var executor = await GetExecutorAsync(services);

// act
var result = await SchemaFileExporter.Export(
System.IO.Path.Combine(_directory, "nested", "schema.graphqls"),
executor,
rewriteToSemanticNonNull: false,
TestContext.Current.CancellationToken);

// assert
Assert.True(File.Exists(result.SchemaFileName));
Assert.True(File.Exists(result.SettingsFileName));
}

public void Dispose()
{
if (Directory.Exists(_directory))
Expand Down
Loading