Repository navigation
Widen the subscription timer reset test's outer deadline to 30 seconds - #10352
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, test-only timeout adjustment that improves reliability without altering the asserted per-event timeout behavior.
Pull request overview
This PR adjusts an overly tight outer test deadline in SubscriptionEventTimeoutTests.Timer_Should_Be_Reset_Between_Events to reduce CI flakiness caused by thread-pool scheduling delays under concurrent test load.
Changes:
- Increased the test-wide
CancellationTokenSourcetimeout from 10 seconds to 30 seconds forTimer_Should_Be_Reset_Between_Events.
File summaries
| File | Description |
|---|---|
| src/HotChocolate/Core/test/Execution.Tests/Pipeline/SubscriptionEventTimeoutTests.cs | Widens the test’s outer cancellation deadline to better tolerate thread-pool contention while keeping the per-event timeout assertion intact. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubscriptionEventTimeoutTests.Timer_Should_Be_Reset_Between_Eventsguarded its whole run with a 10-second CTS and hit it in CI inside aTask.Delay(600), after every event had already completed without errors. The outer guard is now 30 seconds, matching the other tests in the file.Task.Delay), and whenIssue9500Testsruns concurrently its 100k-node DataLoader query fills the pool for the 13 to 18 seconds it takes under coverage. A probe measured a 600 ms delay resuming after 3 seconds with 4335 pending work items. The per-event 1-second budget is armed only after an event is dequeued, so the wider outer guard does not weaken what the test asserts.Test plan
SubscriptionEventTimeoutTestsalone and alongsideIssue9500TestsandStarWarsCodeFirstTestson 4 pinned cores with--coverage: 1.8 s alone, 4.6 to 5.4 s under contention, all green.Issue9500Tests(18 s); the re-run had no overlap and the test took 2.18 s.