Repository navigation
Fix the polygon input execution test passing a single ring literal - #10351
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The updated test input now correctly matches the [[Position]] (list-of-rings) schema contract and the snapshot change reflects the intended successful behavior.
Pull request overview
This PR corrects the GeoJsonPolygonInputTests.Execution_Tests GraphQL literal to match the GeoJSONPolygonInput.coordinates contract ([[Position]] = list of rings), resolving the previously snapshotted validation error and aligning the test with the behavior reported in #9795.
Changes:
- Updated the
coordinatesargument inExecution_Teststo nest positions as a single ring within a list of rings. - Updated the corresponding snapshot to assert successful parsing/execution and the resulting polygon output.
File summaries
| File | Description |
|---|---|
| src/HotChocolate/Spatial/test/Types.Tests/GeoJsonPolygonInputTests.cs | Fixes the test query literal to provide coordinates as a list of rings (correct input shape). |
| src/HotChocolate/Spatial/test/Types.Tests/snapshots/GeoJsonPolygonInputTests.Execution_Tests.snap | Replaces the previously pinned validation error snapshot with the successful execution result snapshot. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Execution_Testsquery inGeoJsonPolygonInputTestspassedcoordinatesas a single ring's positions, a two-level list, whileGeoJSONPolygonInput.coordinateshas been[[Position]], a list of rings, since Fixed Polygon and Multi Polygon #4394. Validation rejected the literal and the snapshot had pinned that error, which GeoJsonPolygonInputType is not parsed correctly #9795 reported as a parser bug.ParseLiteral_*tests in the same class already use the list-of-rings shape.Test plan
HotChocolate.Types.Spatial.Testspasses on net10.0.Closes #9795