Skip to content

Stabilize feature-factory deadlock guard test under CI load - #10287

Merged
glen-84 merged 1 commit into
mainfrom
gai/stabilize-feature-deadlock-guard-test
Aug 24, 2026
Merged

glen-84 merged 1 commit into
mainfrom
gai/stabilize-feature-deadlock-guard-test

Conversation

@glen-84

@glen-84 glen-84 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary

  • GetOrSetSafe_Should_NotDeadlock_When_FactoryRacesLazySelectionSetCompilation intermittently hit its deadlock guard in the Main Branch Coverage workflow: under coverage instrumentation and parallel test load, thread-pool scheduling can delay one side of the test's handshake past its 5s window, and the stalled handshake was then reported as a deadlock.
  • The two racing sides now run on dedicated threads (TaskCreationOptions.LongRunning), making the handshake independent of thread-pool scheduling, and the handshake/completion timeouts are raised to 30s/60s. A genuine deadlock still fails the test at the completion timeout.

Test plan

Copilot AI lite review requested due to automatic review settings August 24, 2026 08:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Stabilizes the feature-factory deadlock regression test under CI load.

Changes:

  • Runs racing operations on dedicated long-running threads.
  • Extends handshake and completion timeouts.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@glen-84
glen-84 merged commit 76400f6 into main Aug 24, 2026
152 checks passed
@glen-84
glen-84 deleted the gai/stabilize-feature-deadlock-guard-test branch August 24, 2026 08:15
This was referenced Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants