Repository navigation
Fix ASB test cases - #10275
Merged
Merged
Fix ASB test cases#10275
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Service Bus transport test suite to align expectations with broker/emulator behavior and to fix test stability issues around naming and message correlation.
Changes:
- Normalize per-test entity name prefixes to lower-kebab form to better match Azure Service Bus naming conventions.
- Fix request/reply concurrency test by ensuring the DI scope (and correlated services) outlives all in-flight requests.
- Update several behavior tests to reflect broker-observed values (dead-letter forwarding target format, inbox recording semantics, and explicit send routing).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Helpers/AzureServiceBusFixture.cs | Normalizes test entity prefix generation (lowercase + kebab) to better match naming conventions. |
| src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Behaviors/RequestReplyTests.cs | Keeps a single DI scope for concurrent requests so responses can be correlated reliably. |
| src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Behaviors/NativeDeadLetterForwardingTests.cs | Adjusts assertion to account for the broker returning an absolute entity URI for forwarding targets. |
| src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Behaviors/InboxTests.cs | Updates inbox expectations when outgoing MessageId is cleared but the broker assigns its own id. |
| src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Behaviors/ErrorQueueTests.cs | Adds explicit dispatch endpoint routing so sends reach the intended handler queue and fault to the correct error queue. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
✅ Nitro CLI E2E snapshots: no flow recordings changed vs |
This was referenced Aug 29, 2026
Merged
This was referenced Sep 8, 2026
Closed
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This was referenced Oct 5, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.