Skip to content

Fix ASB test cases - #10275

Merged
glen-84 merged 2 commits into
mainfrom
pse/fix-zb-test
Aug 21, 2026
Merged

glen-84 merged 2 commits into
mainfrom
pse/fix-zb-test

Conversation

@PascalSenn

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings August 21, 2026 09:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure Service Bus transport test suite to align expectations with broker/emulator behavior and to fix test stability issues around naming and message correlation.

Changes:

  • Normalize per-test entity name prefixes to lower-kebab form to better match Azure Service Bus naming conventions.
  • Fix request/reply concurrency test by ensuring the DI scope (and correlated services) outlives all in-flight requests.
  • Update several behavior tests to reflect broker-observed values (dead-letter forwarding target format, inbox recording semantics, and explicit send routing).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Helpers/AzureServiceBusFixture.cs Normalizes test entity prefix generation (lowercase + kebab) to better match naming conventions.
src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Behaviors/RequestReplyTests.cs Keeps a single DI scope for concurrent requests so responses can be correlated reliably.
src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Behaviors/NativeDeadLetterForwardingTests.cs Adjusts assertion to account for the broker returning an absolute entity URI for forwarding targets.
src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Behaviors/InboxTests.cs Updates inbox expectations when outgoing MessageId is cleared but the broker assigns its own id.
src/Mocha/test/Mocha.Transport.AzureServiceBus.Tests/Behaviors/ErrorQueueTests.cs Adds explicit dispatch endpoint routing so sends reach the intended handler queue and fault to the correct error queue.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Nitro CLI E2E snapshots: no flow recordings changed vs main.

@glen-84 glen-84 changed the title Fixes ASB tests cases Fix ASB test cases Aug 21, 2026
@glen-84
glen-84 merged commit cca477e into main Aug 21, 2026
155 checks passed
@glen-84
glen-84 deleted the pse/fix-zb-test branch August 21, 2026 13:22
This was referenced Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants