Repository navigation
Fix parameter field configuration for source-generated resolvers - #10238
Merged
michaelstaib merged 2 commits intoAug 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a gap where parameter-driven field configuration (middleware/type-system tasks) was not applied for source-generated resolvers (notably when resolver classes are partial), which prevented custom parameter bindings (e.g., LocalState-based parameters) from being configured correctly.
Changes:
- Introduces
IParameterDescriptorFieldConfigurationso parameter field configuration can be applied fromParameterDescriptor(source-generated metadata), not justParameterInfo(reflection). - Extends
ParameterBindingResolverwith anApplyConfiguration(ParameterDescriptor, ObjectFieldDescriptor)path and updates analyzer source generation to invoke it for relevant parameters. - Updates built-in parameter builders and adds integration coverage + snapshot updates for generated output.
Reviewed changes
Copilot reviewed 121 out of 121 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Raven/src/Data/DocumentStoreParameterExpressionBuilder.cs | Implements descriptor-based parameter configuration/binding for Raven session injection. |
| src/HotChocolate/Core/src/Types/Resolvers/ParameterBindingResolver.cs | Collects descriptor-based field configurations and applies them for source-generated parameter descriptors. |
| src/HotChocolate/Core/src/Types/Resolvers/Expressions/Parameters/IsSelectedParameterExpressionBuilder.cs | Migrates IsSelected parameter configuration to descriptor-based configuration (source-gen). |
| src/HotChocolate/Core/src/Types/Internal/IParameterConfigurationBuilder.cs | Adds IParameterDescriptorFieldConfiguration contract for source-generated resolver parameters. |
| src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/TypeFileBuilderBase.cs | Emits generated code to apply parameter field configuration via bindingResolver.ApplyConfiguration(...). |
| src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/Types.cs | Adds integration types + a custom local-state parameter builder to exercise source-gen configuration. |
| src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/ParameterExpressionBuilderTests.cs | Adds integration test asserting parameter field configuration is applied for source-generated resolvers. |
| src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/IsSelectedTests.cs | Adds integration test validating invalid IsSelected patterns are rejected for source-generated resolvers. |
| src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/snapshots/IntegrationTests.Schema_Snapshot.snap | Updates schema snapshot for newly added integration test fields/types. |
| src/HotChocolate/Core/test/Types.Analyzers.Integration.Tests/snapshots/IntegrationTests.Schema_Snapshot_Without_ConnectionName_Inference.snap | Updates schema snapshot variant for newly added integration test fields/types. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ResolverTests.Resolver_With_Multiple_DataLoaders_Same_Name_Different_Namespaces_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ResolverTests.Resolver_With_Generated_DataLoader_Parameter_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ResolverTests.Resolver_With_Generated_DataLoader_From_Different_Namespace_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ResolverTests.Resolver_Parameter_With_Two_Attribute.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ResolverTests.Resolver_Parameter_With_One_Attribute.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ResolverTests.GenerateSource_ResolverWithIsSelectedPattern_MatchesSnapshot.md | Updates generated-code snapshot for IsSelected pattern + emitted parameter descriptor factory. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ResolverTests.GenerateSource_BatchResolverWithCustomParameterBinding_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ResolverTests.Ensure_Entity_Becomes_Node.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ResolverTests.Ensure_Entity_Becomes_Node_With_Query_Node_Resolver.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextProjectionAnalyzerTests.UseProjection_WithoutQueryContext_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextProjectionAnalyzerTests.QueryContext_WithUseProjections_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextProjectionAnalyzerTests.QueryContext_WithUseProjection_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextProjectionAnalyzerTests.QueryContext_WithoutUseProjection_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextProjectionAnalyzerTests.QueryContext_MultipleAttributes_OnlyUseProjectionFlagged.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextProjectionAnalyzerTests.NoQueryContext_NoAttributes_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextConnectionAnalyzerTests.TypeMismatch_WithSubscriptionType_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextConnectionAnalyzerTests.TypeMismatch_WithQueryType_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextConnectionAnalyzerTests.TypeMismatch_WithObjectType_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextConnectionAnalyzerTests.TypeMismatch_WithMutationType_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextConnectionAnalyzerTests.TypeMismatch_WithConnection_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextConnectionAnalyzerTests.NoQueryContextParameter_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextConnectionAnalyzerTests.NoConnectionReturnType_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextConnectionAnalyzerTests.CorrectGenericTypeMatch_WithConnection_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/QueryContextConnectionAnalyzerTests.CorrectGenericTypeMatch_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ParentAttributeAnalyzerTests.ParentAttribute_WithRequires_TypeMismatch_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ParentAttributeAnalyzerTests.ParentAttribute_TypeMismatch_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ParentAttributeAnalyzerTests.ParentAttribute_NoParentAttribute_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ParentAttributeAnalyzerTests.ParentAttribute_MultipleParameters_OnlyParentChecked.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ParentAttributeAnalyzerTests.ParentAttribute_MatchingType_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Shareable_On_Field.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Shareable_On_Class.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Shareable_On_Class_Scoped.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Root_NodeResolver.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Partial_Static_QueryType.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Lookup_With_Generic_ID_Attribute.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Internal_NodeResolver_Is_Added_Without_InternalMember_Option.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Inaccessible_On_Field.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Inaccessible_On_Class.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/OperationTests.Inaccessible_On_Class_Scoped.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_With_InheritdocCref_AllPossibleTargets.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForParameter_WithInheritdoc_WithinParamComment.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForParameter_WithInheritdoc_Is_Overriden_By_ExplicitParamComment.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForParameter_WithInheritdoc_Is_Overriden_By_DescriptionAttribute.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForParameter_WithInheritdoc_AndAdditional_ExplicitParamComment.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForParameter_IsInferred.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForParameter_Is_Overriden_By_DescriptionAttribute.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForParameter_Ignores_ReturnsAndExceptions.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_ThatContainsInheritdoc.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_OnRootLevel_CustomSummary.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_OnRootLevel_CustomReturns.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_OnRootLevel_CustomParam.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_OnRootLevel_CustomException.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_Inside_Summary.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_Inside_Returns.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_Inside_Param.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_Inside_Exception.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.XmlDocumentation_ForMethod_WithInheritdoc_And_MultipleLayersOfInheritance.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.When_parameter_has_inheritdoc_then_it_is_resolved.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.When_method_has_inheritdoc_then_it_is_resolved.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.When_description_has_paramref_tag_then_it_is_converted.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls and adjusts diagnostics locations. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeXmlDocInferenceTests.When_class_implements_interface_and_method_has_description_then_method_parameter_description_is_used.snap | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.XmlDocumentation_With_ParameterDescription.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.XmlDocumentation_With_ComplexScenario.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.NullableValueTypeArgument_With_DefaultValue.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.GraphQLType_String_On_Parameter_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls and shifts diagnostics. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.GraphQLType_On_Resolver_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.GraphQLType_On_Parameter_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.GraphQLType_NonGeneric_On_Parameter_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.Field_Nullable_RefType_Arguments_Nullability_Is_Honored_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.Field_Nullable_Enum_Arguments_Nullability_Is_Honored_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.Field_Arguments_With_DefaultValue_String_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.Field_Arguments_With_DefaultValue_Int_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.Field_Arguments_With_DefaultValue_Enum_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.CustomAttribute_With_Enum_And_Composite_Enum_Arguments_On_Parameter_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.CustomAttribute_On_Parameter_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.BatchResolver_With_Argument_MatchesSnapshot.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ObjectTypeTests.Argument_With_DefaultValue.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/NodeResolverIdParameterAnalyzerTests.MethodWithoutNodeResolver_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsNonNullableTypeAnalyzerTests.Method_ValueTaskNonNullableReturn_RaisesWarning.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsNonNullableTypeAnalyzerTests.Method_TaskNullableReturn_NoWarning.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsNonNullableTypeAnalyzerTests.Method_TaskNonNullableReturn_RaisesWarning.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsNonNullableTypeAnalyzerTests.Method_NullableReturn_NoWarning.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsNonNullableTypeAnalyzerTests.Method_NonNullableReturn_RaisesWarning.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsNonNullableTypeAnalyzerTests.Method_NoLookupAttribute_NoWarning.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsNonNullableTypeAnalyzerTests.Method_FullyQualifiedTaskNullableReturn_NoWarning.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsNonNullableTypeAnalyzerTests.Method_FullyQualifiedTaskNonNullableReturn_RaisesWarning.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsListTypeAnalyzerTests.Method_TaskListReturn_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsListTypeAnalyzerTests.Method_SingleReturn_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsListTypeAnalyzerTests.Method_NoLookupAttribute_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsListTypeAnalyzerTests.Method_ListReturn_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsListTypeAnalyzerTests.Method_IEnumerableReturn_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/LookupReturnsListTypeAnalyzerTests.Method_ArrayReturn_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ExtendObjectTypeAnalyzerTests.ObjectType_WithGenericType_NoInfo.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/ExtendObjectTypeAnalyzerTests.MixedAttributes_OnlyRaisesInfoForExtendObjectType.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/DataAttributeOrderAnalyzerTests.SingleAttribute_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/DataAttributeOrderAnalyzerTests.NoDataAttributes_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/DataAttributeOrderAnalyzerTests.IncorrectOrder_SortingBeforeFiltering_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/DataAttributeOrderAnalyzerTests.IncorrectOrder_ProjectionBeforePaging_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/DataAttributeOrderAnalyzerTests.IncorrectOrder_CompleteReverse_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/DataAttributeOrderAnalyzerTests.CorrectOrder_WithCustomAttributes_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/DataAttributeOrderAnalyzerTests.CorrectOrder_SomeAttributes_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/DataAttributeOrderAnalyzerTests.CorrectOrder_AllAttributes_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/BindMemberAnalyzerTests.BindMember_WithString_ValidMember_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/BindMemberAnalyzerTests.BindMember_WithString_InvalidMember_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/BindMemberAnalyzerTests.BindMember_WithString_InheritedMember_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/BindMemberAnalyzerTests.BindMember_WithNameofSimple_ValidMember_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/BindMemberAnalyzerTests.BindMember_WithNameof_WrongType_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/BindMemberAnalyzerTests.BindMember_WithNameof_ValidMember_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/BindMemberAnalyzerTests.BindMember_WithNameof_InvalidMember_RaisesError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/BindMemberAnalyzerTests.BindMember_WithNameof_InheritedMember_NoError.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/snapshots/BindMemberAnalyzerTests.BindMember_MultipleErrors_RaisesMultipleErrors.md | Updates generated-code snapshot to include parameter descriptor ApplyConfiguration calls. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+47
to
+50
| public void ApplyConfiguration(ParameterDescriptor parameter, ObjectFieldDescriptor descriptor) | ||
| => ApplyPatternConfiguration( | ||
| parameter.Attributes.OfType<IsSelectedAttribute>().Single(), | ||
| descriptor); |
Comment on lines
1
to
4
| using HotChocolate.Execution; | ||
| using HotChocolate.Internal; | ||
| using HotChocolate.Resolvers; | ||
| using Microsoft.Extensions.DependencyInjection; |
Contributor
Patch coverage90.7% of changed lines covered (166/183)
Uncovered changed lines (JSON){
"sha": "be98ea58bd6757030c61bd8e757927e34ea7bb21",
"files": [
{ "path": "src/HotChocolate/Raven/src/Data/DocumentStoreParameterExpressionBuilder.cs", "ranges": [[25, 25], [28, 28], [31, 31], [37, 37]] },
{ "path": "src/HotChocolate/Core/src/Types/Resolvers/ParameterBindingResolver.cs", "ranges": [[119, 123], [125, 129], [199, 201]] }
]
}Project coverage: 54.5% (243161/446418 lines) |
michaelstaib
deleted the
mst/parameter-field-configuration-generated-resolvers
branch
August 15, 2026 15:40
This was referenced Aug 29, 2026
Merged
This was referenced Sep 8, 2026
Closed
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This was referenced Oct 5, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10208