Repository navigation
Report OpenAPI definitions the adapter cannot use - #10218
Merged
Merged
Conversation
Contributor
Patch coverage80.0% of changed lines covered (52/65)
Uncovered changed lines (JSON){
"sha": "3e8794e42b0e5e2e4c98be372f39ad0b1f86ce3f",
"files": [
{ "path": "src/HotChocolate/Adapters/src/Adapters.OpenApi.Core/OpenApiDefinitionRegistry.cs", "ranges": [[203, 203], [205, 210]] },
{ "path": "src/HotChocolate/Adapters/src/Adapters.OpenApi.AspNetCore/DynamicOpenApiDocumentTransformer.cs", "ranges": [[207, 207], [211, 211], [213, 216]] }
]
}Project coverage: 54.4% (242338/445627 lines) |
This was referenced Aug 16, 2026
This was referenced Aug 25, 2026
Closed
Closed
Closed
Closed
This was referenced Sep 1, 2026
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 18 updates
DFE-Digital/SUI_Matcher#397
Closed
This was referenced Sep 1, 2026
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IOpenApiDiagnosticEventListener, naming the definition and the reason. The errors were already being computed and then discarded.KeyNotFoundException, whose message would now reach users verbatim. They throw a message naming the missing fragment or field instead.AddApplicationService<ILogger<T>>()step that listener activation from the schema services requires.Behaviour is otherwise unchanged: an endpoint that cannot execute is still routed and still returns HTTP 500, per the design in #9022.
Test plan
AddApplicationService<ILogger<T>>().HotChocolate.Adapters.OpenApi.Testssuite on net9.0, net10.0, and net11.0: 238 passed, 2 skipped. No snapshot changed.prettier@3.8.3 --no-config --checkon the changed docs page.Reported in #10215. Not a full fix for that issue: making these ordinary validation errors, and failing at startup rather than routing an endpoint that returns HTTP 500, are design decisions still to be made.