Repository navigation
Flatten Fusion result selection set child lookups - #10142
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies Fusion’s ResultSelectionSet child-lookup implementation by removing the small/large subclass split and consolidating lookup strategy (linear scan vs dictionary) into a single sealed type, reducing virtual dispatch overhead while preserving the existing size threshold behavior.
Changes:
- Consolidated
SmallResultSelectionSetandLargeResultSelectionSetbehavior into a single sealedResultSelectionSetwith an optional dictionary-backed child lookup. - Removed the two specialized selection set classes.
- Updated the benchmark to assert lookup strategy via a new
UsesDictionaryLookupindicator instead of concrete subclass types.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/SmallResultSelectionSet.cs | Removed; behavior is now handled inside ResultSelectionSet. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/LargeResultSelectionSet.cs | Removed; behavior is now handled inside ResultSelectionSet. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/ResultSelectionSet.cs | Flattened child lookup logic into one sealed class with an optional dictionary for larger selection sets. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/ResultSelectionSetLookupBenchmark.cs | Updated benchmark assertions to validate lookup strategy rather than relying on concrete types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Patch coverage92.6% of changed lines covered (88/95)
Uncovered changed lines (JSON){
"sha": "38db82d9a8e6edbeced39b7271905e0ca38daa29",
"files": [
{ "path": "src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/ResultSelectionSet.cs", "ranges": [[76, 76], [100, 102], [116, 116], [154, 155]] }
]
}Project coverage: 53.8% (231723/430578 lines) |
This was referenced Aug 6, 2026
Merged
This was referenced Aug 13, 2026
Closed
Closed
This was referenced Aug 25, 2026
Closed
This was referenced Sep 1, 2026
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.