Repository navigation
[Website] Preserve example tabs across the RSC boundary - #10136
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ExampleTabs marker detection across the Next.js RSC → client boundary by switching from component-identity checks (child.type) to a serializable discriminator (exampleTab) passed on the marker elements.
Changes:
- Reworked
ExampleTabsto group tab content by a string union (ExampleTabKind) read from marker props rather than relying onchild.type. - Added an
exampleTabdiscriminator to marker props and updated tab ordering/labeling to use the new kind. - Updated
mdx-components.tsxto wrap MDX marker components and inject the correctexampleTabvalue.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/src/components/ExampleTabs.tsx | Switches marker detection from element type identity to a stable exampleTab discriminator. |
| website/mdx-components.tsx | Wraps MDX marker components to inject exampleTab values for client-side inspection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Aug 6, 2026
Merged
This was referenced Aug 13, 2026
Closed
Closed
This was referenced Aug 25, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.