Skip to content

Streamline source MetaDb row reads in Fusion - #10134

Merged
michaelstaib merged 4 commits into
mainfrom
mst/fusion-metadb-row-reads
Jul 21, 2026
Merged

michaelstaib merged 4 commits into
mainfrom
mst/fusion-metadb-row-reads

Conversation

@michaelstaib

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 21, 2026 22:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes SourceResultDocument.MetaDb row reads by replacing Span/MemoryMarshal.Read-based access with lower-level Unsafe.ReadUnaligned pointer-style reads to reduce overhead on hot paths in Fusion execution.

Changes:

  • Reworked MetaDb.Get(Cursor) to read DbRow via Unsafe.ReadUnaligned.
  • Reworked MetaDb.GetJsonTokenType(Cursor) to read the union field via Unsafe.ReadUnaligned<uint>.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Patch coverage

100.0% of changed lines covered (24/24)

File Covered Changed Patch %
…/Fusion.Execution/Execution/Nodes/OperationExecutionNode.cs 7 7 100.0% 🟢
…/Fusion.Execution/Text/Json/SourceResultDocument.MetaDb.cs 14 14 100.0% 🟢
…/Fusion/src/Fusion.Execution/Text/Json/SourceResultElement.cs 3 3 100.0% 🟢

Project coverage: 53.8% (231352/430213 lines)

@michaelstaib
michaelstaib merged commit 79cb4de into main Jul 21, 2026
6 of 7 checks passed
@michaelstaib
michaelstaib deleted the mst/fusion-metadb-row-reads branch July 21, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants