Skip to content

[Nitro CLI] Return proper not found error for mutation errors #10111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobias-tengler merged 1 commit into from
Jul 13, 2026
Merged

[Nitro CLI] Return proper not found error for mutation errors #10111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Nitro/CommandLine/Nitro.CommandLine.slnx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Solution>
<Folder Name="/src/">
<Project Path="src/CommandLine/Nitro.CommandLine.csproj" />
<Project Path="src/ChilliCream.Nitro.Client/ChilliCream.Nitro.Client.csproj" />
<Project Path="src/CommandLine.FusionCompatibility/Nitro.CommandLine.FusionCompatibility.csproj" />
</Folder>
<Folder Name="/test/">
Expand Down
4 changes: 2 additions & 2 deletions src/Nitro/CommandLine/src/CommandLine/Commands/ApiKeys/CreateApiKeyCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ private async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
IApiNotFoundError err => err.Message,
IApiNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IWorkspaceNotFound err => err.Message,
IPersonalWorkspaceNotSupportedError err => err.Message,
IRoleNotFoundError err => err.Message,
IRoleNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IValidationError err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => "Unexpected mutation error"
Expand Down
2 changes: 1 addition & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/ApiKeys/DeleteApiKeyCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
IApiKeyNotFoundError err => err.Message,
IApiKeyNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
};
Expand Down
2 changes: 2 additions & 0 deletions src/Nitro/CommandLine/src/CommandLine/Commands/Apis/DeleteApiCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = mutationError switch
{
IDeleteApiCommandMutation_DeleteApiById_Errors_ApiNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IError err => Messages.UnexpectedMutationError(err),
Comment thread
tobias-tengler marked this conversation as resolved.
Resolved
_ => Messages.UnexpectedMutationError()
};
Expand Down
3 changes: 2 additions & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Apis/SetApiSettingsCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = mutationError switch
{
ISetApiSettingsCommandMutation_UpdateApiSettings_Errors_ApiNotFoundError err => err.Message,
ISetApiSettingsCommandMutation_UpdateApiSettings_Errors_ApiNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
ISetApiSettingsCommandMutation_UpdateApiSettings_Errors_UnauthorizedOperation err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down
3 changes: 2 additions & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Clients/CreateClientCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
ICreateClientCommandMutation_CreateClient_Errors_ApiNotFoundError err => err.Message,
ICreateClientCommandMutation_CreateClient_Errors_ApiNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
ICreateClientCommandMutation_CreateClient_Errors_UnauthorizedOperation err => err.Message,
ICreateClientCommandMutation_CreateClient_Errors_DuplicateNameError => Messages.DuplicateName(name, "Client"),
IError err => Messages.UnexpectedMutationError(err),
Expand Down
3 changes: 2 additions & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Clients/DeleteClientCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
IDeleteClientByIdCommandMutation_DeleteClientById_Errors_ClientNotFoundError err => err.Message,
IDeleteClientByIdCommandMutation_DeleteClientById_Errors_ClientNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IDeleteClientByIdCommandMutation_DeleteClientById_Errors_UnauthorizedOperation err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down
9 changes: 6 additions & 3 deletions src/Nitro/CommandLine/src/CommandLine/Commands/Clients/PublishClientCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,12 @@ private static async Task<int> ExecuteAsync(
var errorMessage = error switch
{
IPublishClientVersion_PublishClient_Errors_UnauthorizedOperation err => err.Message,
IPublishClientVersion_PublishClient_Errors_ClientNotFoundError err => err.Message,
IPublishClientVersion_PublishClient_Errors_StageNotFoundError err => err.Message,
IPublishClientVersion_PublishClient_Errors_ClientVersionNotFoundError err => err.Message,
IPublishClientVersion_PublishClient_Errors_ClientNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IPublishClientVersion_PublishClient_Errors_StageNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IPublishClientVersion_PublishClient_Errors_ClientVersionNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IPublishClientVersion_PublishClient_Errors_InvalidSourceMetadataInputError err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down
6 changes: 3 additions & 3 deletions src/Nitro/CommandLine/src/CommandLine/Commands/Clients/UnpublishClientCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ private static async Task<int> ExecuteAsync(
var errorMessage = error switch
{
IConcurrentOperationError err => err.Message,
IStageNotFoundError err => err.Message,
IClientVersionNotFoundError err => err.Message,
IStageNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IClientVersionNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IUnauthorizedOperation err => err.Message,
IClientNotFoundError err => err.Message,
IClientNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
};
Expand Down
3 changes: 2 additions & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Clients/UploadClientCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ private static async Task<int> ExecuteAsync(
var errorMessage = error switch
{
IUploadClient_UploadClient_Errors_UnauthorizedOperation err => err.Message,
IUploadClient_UploadClient_Errors_ClientNotFoundError err => err.Message,
IUploadClient_UploadClient_Errors_ClientNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IUploadClient_UploadClient_Errors_DuplicatedTagError err => err.Message,
IUploadClient_UploadClient_Errors_ConcurrentOperationError err => err.Message,
IUploadClient_UploadClient_Errors_InvalidPersistedQueryError err => err.Message,
Expand Down
6 changes: 4 additions & 2 deletions src/Nitro/CommandLine/src/CommandLine/Commands/Clients/ValidateClientCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,10 @@ private static async Task<int> ExecuteAsync(
var errorMessage = error switch
{
IValidateClientVersion_ValidateClient_Errors_UnauthorizedOperation err => err.Message,
IValidateClientVersion_ValidateClient_Errors_ClientNotFoundError err => err.Message,
IValidateClientVersion_ValidateClient_Errors_StageNotFoundError err => err.Message,
IValidateClientVersion_ValidateClient_Errors_ClientNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IValidateClientVersion_ValidateClient_Errors_StageNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IValidateClientVersion_ValidateClient_Errors_InvalidSourceMetadataInputError err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down
3 changes: 2 additions & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,8 @@ await FusionPublishHelpers.ClaimDeploymentSlotAsync(
var errorMessage = error switch
{
IUnauthorizedOperation err => err.Message,
IFusionConfigurationRequestNotFoundError err => err.Message,
IFusionConfigurationRequestNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IInvalidProcessingStateTransitionError err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down
13 changes: 8 additions & 5 deletions src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ public static async Task<string> RequestDeploymentSlotAsync(
{
IUnauthorizedOperation err => err.Message,
IInvalidSourceMetadataInputError err => err.Message,
IApiNotFoundError err => err.Message,
IStageNotFoundError err => err.Message,
IApiNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IStageNotFoundError err => throw new NitroClientNotFoundException(err.Message),
ISubgraphInvalidError err => err.Message,
IInvalidProcessingStateTransitionError err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
Expand Down Expand Up @@ -157,7 +157,8 @@ public static async Task ClaimDeploymentSlotAsync(
var errorMessage = error switch
{
IUnauthorizedOperation err => err.Message,
IFusionConfigurationRequestNotFoundError err => err.Message,
IFusionConfigurationRequestNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IInvalidProcessingStateTransitionError err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down Expand Up @@ -189,7 +190,8 @@ public static async Task<bool> UploadFusionConfigurationAsync(
var errorMessage = error switch
{
IUnauthorizedOperation err => err.Message,
IFusionConfigurationRequestNotFoundError err => err.Message,
IFusionConfigurationRequestNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IInvalidProcessingStateTransitionError err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down Expand Up @@ -321,7 +323,8 @@ public static async Task<bool> ValidateFusionConfigurationAsync(
var errorMessage = error switch
{
IUnauthorizedOperation err => err.Message,
IFusionConfigurationRequestNotFoundError err => err.Message,
IFusionConfigurationRequestNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IInvalidProcessingStateTransitionError err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down
2 changes: 2 additions & 0 deletions src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionUploadCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ private static async Task<int> ExecuteAsync(
var errorMessage = error switch
{
IUnauthorizedOperation err => err.Message,
IUploadFusionSubgraph_UploadFusionSubgraph_Errors_ApiNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IInvalidSourceMetadataInputError err => err.Message,
IDuplicatedTagError err => err.Message,
IConcurrentOperationError err => err.Message,
Expand Down
3 changes: 2 additions & 1 deletion ...src/CommandLine/Commands/Fusion/PublishCommand/FusionConfigurationPublishCancelCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ await FusionConfigurationPublishingState.GetRequestId(fileSystem, cancellationTo
var errorMessage = error switch
{
IUnauthorizedOperation err => err.Message,
IFusionConfigurationRequestNotFoundError err => err.Message,
IFusionConfigurationRequestNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IInvalidProcessingStateTransitionError err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down
2 changes: 1 addition & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/CreateMcpFeatureCollectionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
IApiNotFoundError err => err.Message,
IApiNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IUnauthorizedOperation err => err.Message,
IDuplicateNameError => Messages.DuplicateName(name, "MCP Feature Collection"),
IError err => Messages.UnexpectedMutationError(err),
Expand Down
3 changes: 2 additions & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/DeleteMcpFeatureCollectionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
IMcpFeatureCollectionNotFoundError err => err.Message,
IMcpFeatureCollectionNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IUnauthorizedOperation err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down
8 changes: 5 additions & 3 deletions src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/PublishMcpFeatureCollectionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,11 @@ private static async Task<int> ExecuteAsync(
{
IUnauthorizedOperation err => err.Message,
IPublishMcpFeatureCollectionCommandMutation_PublishMcpFeatureCollection_Errors_InvalidSourceMetadataInputError err => err.Message,
IStageNotFoundError err => err.Message,
IMcpFeatureCollectionNotFoundError err => err.Message,
IMcpFeatureCollectionVersionNotFoundError err => err.Message,
IStageNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IMcpFeatureCollectionNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IMcpFeatureCollectionVersionNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
};
Expand Down
3 changes: 2 additions & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/UploadMcpFeatureCollectionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ await McpFeatureCollectionHelpers.BuildMcpFeatureCollectionArchive(
{
var errorMessage = error switch
{
IMcpFeatureCollectionNotFoundError err => err.Message,
IMcpFeatureCollectionNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IUnauthorizedOperation err => err.Message,
IInvalidSourceMetadataInputError err => err.Message,
IDuplicatedTagError err => err.Message,
Expand Down
5 changes: 3 additions & 2 deletions src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/ValidateMcpFeatureCollectionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@ await McpFeatureCollectionHelpers.BuildMcpFeatureCollectionArchive(
{
IUnauthorizedOperation err => err.Message,
IInvalidSourceMetadataInputError err => err.Message,
IStageNotFoundError err => err.Message,
IMcpFeatureCollectionNotFoundError err => err.Message,
IStageNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IMcpFeatureCollectionNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
};
Expand Down
2 changes: 1 addition & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Mocks/CreateMockCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
IApiNotFoundError err => err.Message,
IApiNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IMockSchemaNonUniqueNameError err => err.Message,
IUnauthorizedOperation err => err.Message,
IValidationError err => err.Message,
Expand Down
2 changes: 1 addition & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/Mocks/UpdateMockCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
IMockSchemaNotFoundError err => err.Message,
IMockSchemaNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IMockSchemaNonUniqueNameError err => err.Message,
IUnauthorizedOperation err => err.Message,
IValidationError err => err.Message,
Expand Down
2 changes: 1 addition & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/CreateOpenApiCollectionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
IApiNotFoundError err => err.Message,
IApiNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IUnauthorizedOperation err => err.Message,
IDuplicateNameError => Messages.DuplicateName(name, "OpenAPI Collection"),
IError err => Messages.UnexpectedMutationError(err),
Expand Down
3 changes: 2 additions & 1 deletion src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/DeleteOpenApiCollectionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ private static async Task<int> ExecuteAsync(
{
var errorMessage = error switch
{
IOpenApiCollectionNotFoundError err => err.Message,
IOpenApiCollectionNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IUnauthorizedOperation err => err.Message,
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
Expand Down
8 changes: 5 additions & 3 deletions src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/PublishOpenApiCollectionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,11 @@ private static async Task<int> ExecuteAsync(
{
IUnauthorizedOperation err => err.Message,
IInvalidSourceMetadataInputError err => err.Message,
IStageNotFoundError err => err.Message,
IOpenApiCollectionNotFoundError err => err.Message,
IOpenApiCollectionVersionNotFoundError err => err.Message,
IStageNotFoundError err => throw new NitroClientNotFoundException(err.Message),
IOpenApiCollectionNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IOpenApiCollectionVersionNotFoundError err =>
throw new NitroClientNotFoundException(err.Message),
IError err => Messages.UnexpectedMutationError(err),
_ => Messages.UnexpectedMutationError()
};
Expand Down
Loading
Loading