Skip to content

[Fusion] Avoid a duplicate selection row read when initializing composite objects #10078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 2 commits into from
Jul 10, 2026
Merged

[Fusion] Avoid a duplicate selection row read when initializing composite objects #10078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c2970e
[Fusion] Avoid a duplicate selection row read when initializing compo…
michaelstaib Jul 9, 2026
cbbd4c1
Merge branch 'main' into mst/value-fast
michaelstaib Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/ValueCompletion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,17 @@ private static bool TryGetSelectionContext(
[NotNullWhen(true)] out Selection? selection,
[NotNullWhen(true)] out IType? type)
{
// Fast path: a direct-field target carries its own selection on the
// preceding property row. Reading that selection once lets us derive
// the type from it, avoiding a second metadb read via the Type getter.
selection = target.Selection;

if (selection is not null)
{
type = selection.Type;
return true;
}

type = target.Type;

if (type is null)
Expand Down
Loading