Skip to content

Enable Git long paths on Windows release checkout - #10070

Merged
glen-84 merged 1 commit into
mainfrom
gai/release-windows-git-longpaths
Jul 8, 2026
Merged

glen-84 merged 1 commit into
mainfrom
gai/release-windows-git-longpaths

Conversation

@glen-84

@glen-84 glen-84 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

  • The build-nitro-cli matrix job checks out the repo on windows-2025, where some Fusion snapshot paths exceed the Windows MAX_PATH limit and fail actions/checkout with Filename too long.
  • Add a Windows-gated step that runs git config --system core.longpaths true before checkout. Uses --system because actions/checkout overrides HOME (and thus global config) for its run but honors system config.
  • Add libgcc, libstdc, and longpaths to the spell-check dictionary.

Test plan

  • Verified by inspection: step is gated to Windows, ordered before the checkout step, and sets the config at system scope. Effective coverage is the next release run on the Windows legs (win-x64, win-x86).

Copilot AI review requested due to automatic review settings July 8, 2026 13:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Windows release-checkout failures caused by long file paths exceeding Windows MAX_PATH during actions/checkout in the build-nitro-cli matrix job.

Changes:

  • Adds a Windows-gated step to enable Git long path support (core.longpaths=true) before actions/checkout runs in the release workflow.
  • Updates the repository spell-check dictionary to allow libgcc, libstdc, and longpaths.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
dictionary.txt Adds a few workflow/tooling-related tokens to the spell-check allowlist.
.github/workflows/release.yml Enables Git long path support on Windows runners prior to checkout to prevent path-length failures.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@glen-84
glen-84 merged commit 92345f3 into main Jul 8, 2026
144 of 147 checks passed
@glen-84
glen-84 deleted the gai/release-windows-git-longpaths branch July 8, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants