Repository navigation
[Fusion] Match abstract type conditions in fetch result path walkers - #10065
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Fusion fetch-result path walking so inline-fragment type conditions can match abstract types (interfaces/unions) against concrete runtime __typename, addressing #10045 and preventing lookups from being skipped when reached through interface fragments.
Changes:
- Updated
FetchResultStorepath walking to treat inline-fragment type conditions as abstract-capable and perform subtype/union-member matching. - Added planning tests to ensure lookup targets keep abstract type conditions when reached through interface fragments.
- Added execution tests + snapshots covering interface inheritance chains and union source-path narrowing by type condition.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/FetchResultStore.cs | Implements subtype-aware inline-fragment matching for both target and source path walkers. |
| src/HotChocolate/Fusion/test/Fusion.Execution.Tests/Planning/InterfaceInheritanceLookupPlanningTests.cs | Adds regression tests validating abstract vs concrete type conditions in planned fetch targets. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/InterfaceInheritanceExecutionTests.cs | Adds execution-level coverage for interface inheritance + union lookups/type conditions. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/snapshots/InterfaceInheritanceExecutionTests.Execution_Should_ResolveUnionMemberField_When_LookupNarrowsSourcePathByTypeCondition.yaml | Snapshot for union source-path narrowing behavior. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/snapshots/InterfaceInheritanceExecutionTests.Execution_Should_ResolveProduct_When_LookupReachedThroughTopLevelInterfaceFragment.yaml | Snapshot for top-level interface fragment lookup execution. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/snapshots/InterfaceInheritanceExecutionTests.Execution_Should_ResolveProduct_When_LookupReachedThroughNestedInterfaceHierarchy.yaml | Snapshot for nested interface hierarchy lookup execution. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/snapshots/InterfaceInheritanceExecutionTests.Execution_Should_ResolveProduct_When_LookupReachedThroughDirectIntermediateInterfaceFragment.yaml | Snapshot for direct intermediate interface fragment lookup execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 13, 2026
This was referenced Jul 20, 2026
chore(deps): Bump HotChocolate.Subscriptions.InMemory from 15.1.14 to 16.5.1
Kuestenlogik/Bowire#506
Merged
This was referenced Aug 1, 2026
This was referenced Sep 1, 2026
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10045