Enable IDE0370 and remove unnecessary suppression operators

.editorconfig

@@ -275,6 +275,8 @@ dotnet_diagnostic.IDE0305.severity = silent # see https://github.com/dotnet/rosl
 # Use collection expression for new.
 dotnet_diagnostic.IDE0306.severity = warning
 dotnet_style_prefer_collection_expression = when_types_exactly_match
+# Remove unnecessary suppression.
+dotnet_diagnostic.IDE0370.severity = warning
 # Place new line after/before binary operator.
 dotnet_diagnostic.RCS0027.severity = warning
 roslynator_binary_operator_new_line = before

src/GreenDonut/src/GreenDonut/BatchDataLoader.cs

@@ -53,7 +53,7 @@ private static void CopyResults(
         {
             if (resultMap.TryGetValue(keys[i], out var value))
             {
-                results[i] = value!;
+                results[i] = value;
             }
             else
             {

src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/Endpoints/HttpEndpointIntegrationTestBase.cs

@@ -624,7 +624,7 @@ await SpinWaitAsync(async () =>
             return response2.StatusCode == HttpStatusCode.OK;
         }, cts.Token);
 
-        response2!.MatchSnapshot();
+        response2.MatchSnapshot();
     }
 
     [Fact]
@@ -669,7 +669,7 @@ await SpinWaitAsync(async () =>
             return content != content1;
         }, cts.Token);
 
-        response2!.MatchSnapshot();
+        response2.MatchSnapshot();
     }
 
     [Fact]
@@ -718,7 +718,7 @@ await SpinWaitAsync(async () =>
 
         Assert.Equal(HttpStatusCode.NotFound, oldRouteResponse2.StatusCode);
 
-        newRouteResponse!.MatchSnapshot();
+        newRouteResponse.MatchSnapshot();
     }
 
     [Fact]

src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/OpenApi/OpenApiIntegrationTestBase.cs

@@ -567,7 +567,7 @@ await SpinWaitAsync(async () =>
             return openApiDocument2 != openApiDocument1;
         }, cts.Token);
 
-        openApiDocument2!.MatchSnapshot(postFix: TestEnvironment.TargetFramework, extension: ".json");
+        openApiDocument2.MatchSnapshot(postFix: TestEnvironment.TargetFramework, extension: ".json");
     }
 
     [Fact]
@@ -610,7 +610,7 @@ await SpinWaitAsync(async () =>
             return openApiDocument2 != openApiDocument1;
         }, cts.Token);
 
-        openApiDocument2!.MatchSnapshot(postFix: TestEnvironment.TargetFramework, extension: ".json");
+        openApiDocument2.MatchSnapshot(postFix: TestEnvironment.TargetFramework, extension: ".json");
     }
 
     [Fact]
@@ -653,7 +653,7 @@ await SpinWaitAsync(async () =>
             return openApiDocument2 != openApiDocument1;
         }, cts.Token);
 
-        openApiDocument2!.MatchSnapshot(postFix: TestEnvironment.TargetFramework, extension: ".json");
+        openApiDocument2.MatchSnapshot(postFix: TestEnvironment.TargetFramework, extension: ".json");
     }
 
     [Fact(Skip = "Need to determine what best behavior should be")]
@@ -722,7 +722,7 @@ await SpinWaitAsync(async () =>
             return openApiDocument2 != openApiDocument1;
         }, cts.Token);
 
-        openApiDocument2!.MatchSnapshot(postFix: TestEnvironment.TargetFramework, extension: ".json");
+        openApiDocument2.MatchSnapshot(postFix: TestEnvironment.TargetFramework, extension: ".json");
     }
 
     [Fact]

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/ExternalDirectiveTests.cs

@@ -31,11 +31,11 @@ public async Task AnnotateExternalToTypeFieldCodeFirst()
                         .Resolve(_ => 1);
                     o.Field("idCode")
                         .Type<StringType>()
-                        .Resolve(_ => default!)
+                        .Resolve(_ => default)
                         .External();
                     o.Field("address")
                         .Type("Address")
-                        .Resolve(_ => default!)
+                        .Resolve(_ => default)
                         .External();
                 })
             .AddObjectType(
@@ -45,10 +45,10 @@ public async Task AnnotateExternalToTypeFieldCodeFirst()
                     o.External();
                     o.Field("street")
                         .Type<StringType>()
-                        .Resolve(_ => default!);
+                        .Resolve(_ => default);
                     o.Field("city")
                         .Type<StringType>()
-                        .Resolve(_ => default!);
+                        .Resolve(_ => default);
                 })
             .BuildSchemaAsync(cancellationToken: TestContext.Current.CancellationToken);
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/Legacy/ExternalDirectiveTests.cs

@@ -31,7 +31,7 @@ public async Task AnnotateExternalToTypeFieldCodeFirst()
                         .Resolve(_ => 1);
                     o.Field("idCode")
                         .Type<StringType>()
-                        .Resolve(_ => default!)
+                        .Resolve(_ => default)
                         .External();
                 })
             .BuildSchemaAsync(cancellationToken: TestContext.Current.CancellationToken);

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/Legacy/ProvidesDirectiveTests.cs

@@ -19,26 +19,26 @@ public async Task AnnotateProvidesToFieldCodeFirst()
                     o.Name("Product");
                     o.Field("name")
                         .Type<StringType>()
-                        .Resolve(_ => default!);
+                        .Resolve(_ => default);
                 })
             .AddObjectType(o =>
             {
                 o.Name("Review").Key("id");
                 o.Field("id")
                     .Type<IntType>()
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
                 o.Field("product")
                     .Provides("name")
                     .Type("Product")
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
             })
             .AddQueryType(o =>
                 {
                     o.Name("Query");
                     o.Field("someField")
                         .Argument("a", a => a.Type<IntType>())
                         .Type("Review")
-                        .Resolve(_ => default!);
+                        .Resolve(_ => default);
                 })
             .BuildSchemaAsync(cancellationToken: TestContext.Current.CancellationToken);
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/Legacy/RequiresDirectiveTests.cs

@@ -19,26 +19,26 @@ public async Task AnnotateProvidesToFieldCodeFirst()
                 o.Name("Product");
                 o.Field("name")
                     .Type<StringType>()
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
             })
             .AddObjectType(o =>
             {
                 o.Name("Review").Key("id");
                 o.Field("id")
                     .Type<IntType>()
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
                 o.Field("product")
                     .Requires("id")
                     .Type("Product")
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
             })
             .AddQueryType(o =>
             {
                 o.Name("Query");
                 o.Field("someField")
                     .Argument("a", a => a.Type<IntType>())
                     .Type("Review")
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
             })
             .BuildSchemaAsync(cancellationToken: TestContext.Current.CancellationToken);
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/PolicyDirectiveTests.cs

@@ -74,7 +74,7 @@ private static string[][] GetSinglePoliciesArgument(DirectiveCollection directiv
         }
 
         Assert.Fail("No policy directive found.");
-        return null!;
+        return null;
     }
 
     private static void CheckQueryType(Schema schema)

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/ProvidesDirectiveTests.cs

@@ -19,26 +19,26 @@ public async Task AnnotateProvidesToFieldCodeFirst()
                     o.Name("Product");
                     o.Field("name")
                         .Type<StringType>()
-                        .Resolve(_ => default!);
+                        .Resolve(_ => default);
                 })
             .AddObjectType(o =>
             {
                 o.Name("Review").Key("id");
                 o.Field("id")
                     .Type<IntType>()
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
                 o.Field("product")
                     .Provides("name")
                     .Type("Product")
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
             })
             .AddQueryType(o =>
                 {
                     o.Name("Query");
                     o.Field("someField")
                         .Argument("a", a => a.Type<IntType>())
                         .Type("Review")
-                        .Resolve(_ => default!);
+                        .Resolve(_ => default);
                 })
             .BuildSchemaAsync(cancellationToken: TestContext.Current.CancellationToken);
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/RequiresDirectiveTests.cs

@@ -19,26 +19,26 @@ public async Task AnnotateProvidesToFieldCodeFirst()
                 o.Name("Product");
                 o.Field("name")
                     .Type<StringType>()
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
             })
             .AddObjectType(o =>
             {
                 o.Name("Review").Key("id");
                 o.Field("id")
                     .Type<IntType>()
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
                 o.Field("product")
                     .Requires("id")
                     .Type("Product")
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
             })
             .AddQueryType(o =>
             {
                 o.Name("Query");
                 o.Field("someField")
                     .Argument("a", a => a.Type<IntType>())
                     .Type("Review")
-                    .Resolve(_ => default!);
+                    .Resolve(_ => default);
             })
             .BuildSchemaAsync(cancellationToken: TestContext.Current.CancellationToken);
 

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/RequiresScopesDirectiveTests.cs

@@ -74,7 +74,7 @@ private static string[][] GetSingleRequiresScopesArgument(DirectiveCollection di
         }
 
         Assert.Fail("No requires scopes directive found.");
-        return null!;
+        return null;
     }
 
     private static void CheckQueryType(Schema schema)

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Support/ParsingHelper.cs

@@ -9,13 +9,13 @@ public static string[][] ParsePolicyDirectiveNode(IValueNode node)
         if (node is not ListValueNode list)
         {
             Assert.Fail("Expected ListValueNode result.");
-            return null!;
+            return null;
         }
 
         if (list.Items is not [ListValueNode innerList])
         {
             Assert.Fail("Expected inner ListValueNode result.");
-            return null!;
+            return null;
         }
 
         return innerList.Items
@@ -29,13 +29,13 @@ public static string[][] ParseRequiresScopesDirectiveNode(IValueNode node)
         if (node is not ListValueNode list)
         {
             Assert.Fail("Expected ListValueNode result.");
-            return null!;
+            return null;
         }
 
         if (list.Items is not [ListValueNode innerList])
         {
             Assert.Fail("Expected inner ListValueNode result.");
-            return null!;
+            return null;
         }
 
         return innerList.Items

src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Utilities/MiddlewareHelper.cs

@@ -19,7 +19,7 @@ public static ValidateAcceptContentTypeResult ValidateAcceptContentType(
         // with a 400 Bad Request.
         if (headerResult.HasError)
         {
-            var errors = headerResult.ErrorResult.Errors!;
+            var errors = headerResult.ErrorResult.Errors;
             executorSession.DiagnosticEvents.HttpRequestError(context, errors[0]);
 
             return new ValidateAcceptContentTypeResult(

src/HotChocolate/AspNetCore/src/Transport.Http/DefaultGraphQLHttpClient.cs

@@ -440,21 +440,21 @@ private static Uri CreateGetRequestUri(
         {
             AppendAmpersand(sb, ref appendAmpersand);
             sb.Append("id=");
-            sb.Append(Uri.EscapeDataString(or.Id!));
+            sb.Append(Uri.EscapeDataString(or.Id));
         }
 
         if (!string.IsNullOrWhiteSpace(or.Query))
         {
             AppendAmpersand(sb, ref appendAmpersand);
             sb.Append("query=");
-            sb.Append(Uri.EscapeDataString(or.Query!));
+            sb.Append(Uri.EscapeDataString(or.Query));
         }
 
         if (!string.IsNullOrWhiteSpace(or.OperationName))
         {
             AppendAmpersand(sb, ref appendAmpersand);
             sb.Append("operationName=");
-            sb.Append(Uri.EscapeDataString(or.OperationName!));
+            sb.Append(Uri.EscapeDataString(or.OperationName));
         }
 
         if (or.OnError is { } errorHandlingMode)

src/HotChocolate/AspNetCore/test/AspNetCore.Tests.Utilities/UploadQuery.cs

@@ -90,7 +90,7 @@ public class FileInfoOutput
 public class InputWithOptionalFile
 {
     [GraphQLType(typeof(UploadType))]
-    public Optional<IFile> File { get; set; } = default!;
+    public Optional<IFile> File { get; set; }
 }
 
 public class InputWithFile

src/HotChocolate/AspNetCore/test/AspNetCore.Tests/Serialization/VariablePathTests.cs

@@ -59,7 +59,7 @@ public void ValidPath()
         // assert
         Assert.Equal("foo", path.Key.Value);
         Assert.Equal("bar", Assert.IsType<KeyPathSegment>(path.Key.Next).Value);
-        Assert.Equal(1, Assert.IsType<IndexPathSegment>(path.Key.Next!.Next).Value);
-        Assert.Equal("baz", Assert.IsType<KeyPathSegment>(path.Key.Next!.Next!.Next).Value);
+        Assert.Equal(1, Assert.IsType<IndexPathSegment>(path.Key.Next.Next).Value);
+        Assert.Equal("baz", Assert.IsType<KeyPathSegment>(path.Key.Next.Next.Next).Value);
     }
 }