Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translation files #22

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

NathanBnm
Copy link
Contributor

@NathanBnm NathanBnm commented Aug 14, 2021

Hello ! I improved the translations files. I properly added missing headers for the main translation files and fixed missing metadata translation files as well (translations were just the same than the main ones).

I also removed the en-gb files because it's the default language so translation file is not needed.

Just let me know if you have any questions. Would be happy to add French translation after this PR would be merged 😄

@ChildishGiant
Copy link
Owner

I'd love if you could give the changes I've just made a once-over to make sure everything's right. Thanks!

@NathanBnm
Copy link
Contributor Author

@ChildishGiant everything is fine 😄

@ChildishGiant ChildishGiant merged commit 2716cbf into ChildishGiant:main Aug 16, 2021
@ChildishGiant
Copy link
Owner

@all-contributors please add @NathanBnm for translation

@allcontributors
Copy link
Contributor

@ChildishGiant

I've put up a pull request to add @NathanBnm! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants