-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Assign Event Tracking (M2-7607) #1961
Open
sultanofcardio
wants to merge
17
commits into
develop
Choose a base branch
from
feature/M2-7607-assign-event-tracking
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+759
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've removed the `Entity Type` and `Activity ID`/`Activity Flow ID` properties for the ConfirmAssignActivityOrFlowEvent type because assignments can involve multiple activities and flows. Further, the event already has `Activity count` and `Flow count` properties
There was also an extra one of these events that gets triggered by the unsaved changes dialog. This is unnecessary, so I removed it.
This pull request is automatically being deployed by Amplify Hosting (learn more). |
farmerpaul
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Code looks good, just noticed a couple issues with simple fixes, so preapproving!
src/modules/Dashboard/components/ActivityAssignDrawer/ActivityAssignDrawer.tsx
Outdated
Show resolved
Hide resolved
src/modules/Dashboard/features/RespondentData/RespondentDataHeader/RespondentDataHeader.tsx
Outdated
Show resolved
Hide resolved
farmerpaul
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-7607
This PR adds the following events to Mixpanel tracking:
Start Assign Activity/Flow
Confirm Assign Activity/Flow
Start Unassign Activity/Flow
Confirm Unassign Activity/Flow
It also updates the
Applet Save click
event to add some extra properties related to activity and flow assignments📸 Screenshots
N/A
🪤 Peer Testing
Perform the following actions and confirm in the Mindlogger Analytics Dev project in Mixpanel that the proper events show up with the properties specified in the ticket:
Applet Save click
event has the updated properties as specified in the ticket✏️ Notes