Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Assign Event Tracking (M2-7607) #1961

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

sultanofcardio
Copy link
Contributor

@sultanofcardio sultanofcardio commented Oct 26, 2024

  • Tests for the changes have been added

📝 Description

🔗 Jira Ticket M2-7607

This PR adds the following events to Mixpanel tracking:

  • Start Assign Activity/Flow
  • Confirm Assign Activity/Flow
  • Start Unassign Activity/Flow
  • Confirm Unassign Activity/Flow

It also updates the Applet Save click event to add some extra properties related to activity and flow assignments

📸 Screenshots

N/A

🪤 Peer Testing

Perform the following actions and confirm in the Mindlogger Analytics Dev project in Mixpanel that the proper events show up with the properties specified in the ticket:

  • Perform an activity/flow assignment and un-assignment from the Applet Activities tab using the button in the toolbar
  • Perform an activity/flow assignment and un-assignment from the Applet Activities tab using the more menu on the activity card
  • Perform an activity/flow assignment and un-assignment from the Participant Assignment tab
  • Perform an activity/flow assignment and un-assignment from the Data Viz page
  • Make a minor change to the applet (like changing the name) and confirm that the Applet Save click event has the updated properties as specified in the ticket

✏️ Notes

I've removed the `Entity Type` and `Activity ID`/`Activity Flow ID` properties for the ConfirmAssignActivityOrFlowEvent type because assignments can involve multiple activities and flows. Further, the event already has `Activity count` and `Flow count` properties
There was also an extra one of these events that gets triggered by the unsaved changes dialog. This is unnecessary, so I removed it.
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1961.d19gtpld8yi51u.amplifyapp.com

Copy link
Contributor

@farmerpaul farmerpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Code looks good, just noticed a couple issues with simple fixes, so preapproving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants