Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teensy 3.6: do not restart USB stack after wakeup #346

Closed

Conversation

stapelberg
Copy link
Contributor

Without this change, the Teensy 3.6 (with QMK firmware) can wake a computer from Suspend-to-RAM, but the keyboard does not actually produce any keypresses until you un-plug and re-plug it.

A similar change was needed for the Teensy 4.x as well: #345

related to kinx-project/kint#59

related to qmk/qmk_firmware#16934

Without this change, the Teensy 3.6 (with QMK firmware) can wake a computer from
Suspend-to-RAM, but the keyboard does not actually produce any keypresses until
you un-plug and re-plug it.

A similar change was needed for the Teensy 4.x as well:
ChibiOS#345

related to kinx-project/kint#59

related to qmk/qmk_firmware#16934
@stapelberg
Copy link
Contributor Author

I’m getting the feeling that the restart_usb_driver function should be defined in QMK instead of in ChibiOS-Contrib (though there is precedent in ChibiOS-Contrib/os/hal/boards/SN_SN32F240/board.c!), but that probably requires switching from ChibiOS-Contrib’s PJRC_TEENSY_3_6 board definition to creating a QMK-specific IC_TEENSY_3_6 board definition…

@fpoussin
Copy link
Member

fpoussin commented Nov 3, 2022

/home/runner/work/ChibiOS-Contrib/ChibiOS-Contrib/os/hal/boards/PJRC_TEENSY_3_6/board.c:218:25: error: unknown type name 'USBDriver'

Maybe a condition would do the job here?

@stapelberg
Copy link
Contributor Author

Maybe a condition would do the job here?

Nah, I’m pretty certain now that the code in question belongs into QMK, as the restart_usb_driver function is only defined in QMK. I created qmk/qmk_firmware#19077 to make that change.

@stapelberg stapelberg closed this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants