CHIA-2378: Add CLI commands to import, export, and benchmark the mempool #19271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigidity
changed the title
emlowe
added
the
Added
AmineKhaldi
reviewed
Feb 15, 2025
| from chia.cmds.cmds_util import get_any_service_client | ||
|
|
||
| async with get_any_service_client(FullNodeRpcClient, root_path, rpc_port) as (node_client, _): | ||
| start = time.time() |
There was a problem hiding this comment.
Suggested change
| start = time.time() | |
| start = time.monotonic() |
| async with get_any_service_client(FullNodeRpcClient, root_path, rpc_port) as (node_client, _): | ||
| start = time.time() | ||
| bundle = await node_client.create_block_bundle_from_mempool() | ||
| end = time.time() |
There was a problem hiding this comment.
Suggested change
| end = time.time() | |
| end = time.monotonic() |
| curr_l_tb = self.service.blockchain.block_record(curr_l_tb.prev_hash) | ||
|
|
||
| self.service.log.info("Beginning simulated block construction from mempool") | ||
| start_time = time.time() |
There was a problem hiding this comment.
Suggested change
| start_time = time.time() | |
| start_time = time.monotonic() |
| self.service.log.error(f"Traceback: {traceback.format_exc()}") | ||
| self.service.log.error(f"Error making spend bundle {e} peak: {peak}") | ||
| mempool_bundle = None | ||
| self.service.log.info(f"Simulated block constructed in {time.time() - start_time} seconds") |
There was a problem hiding this comment.
Suggested change
| self.service.log.info(f"Simulated block constructed in {time.time() - start_time} seconds") | |
| self.service.log.info(f"Simulated block constructed in {time.monotonic() - start_time} seconds") |
arvidn
reviewed
Feb 19, 2025
| start_time = time.time() | ||
|
|
||
| try: | ||
| result = await self.service.mempool_manager.create_bundle_from_mempool( |
There was a problem hiding this comment.
I think it would be better to call create_block_generator(), to also include the time it takes to serialize/compress the block
| @@ -835,6 +838,38 @@ async def get_mempool_items_by_coin_name(self, request: dict[str, Any]) -> Endpo | |||
|
|
|||
| return {"mempool_items": [item.to_json_dict() for item in items]} | |||
|
|
|||
| async def create_block_bundle_from_mempool(self, _: dict[str, Any]) -> EndpointResult: | |||
There was a problem hiding this comment.
I think the "from mempool" part of this name is implied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
chia dev mempoolCLI group withimport,export, andcreate_blockcommands.