Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1437]: Reduce level log spam when downloading DAT files #18610

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Sep 19, 2024

The previous code printed out a log line for each chunk downloaded while downloading DAT files at the INFO level. This would often result in up to 100 log entries for each file at INFO.

This sets the log level to DEBUG and should print 4 lines per file in most cases.

@emlowe emlowe requested a review from a team as a code owner September 19, 2024 21:27
@emlowe emlowe changed the title Reduce level log spam when downloading files Reduce level log spam when downloading DL DAT files Sep 19, 2024
@emlowe emlowe changed the title Reduce level log spam when downloading DL DAT files [CHIA-1437]: Reduce level log spam when downloading DAT files Sep 19, 2024
@emlowe emlowe added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 19, 2024
Copy link
Contributor

File Coverage Missing Lines
chia/data_layer/download_data.py 0.0% lines 380
Total Missing Coverage
Unknown Unknown 0%

@pmaslana pmaslana merged commit c0c12b9 into main Sep 27, 2024
374 of 375 checks passed
@pmaslana pmaslana deleted the EL.dl-reduce-log-spam branch September 27, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants