Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelord logging: Updated peak to hex from bytestring #18467

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

hoffmang9
Copy link
Member

Purpose:

Improve readability and block tracing in Timelord logs

Current Behavior:

Updated timelord peak to b'\\Ea\xf4\xc0\x93z\x9f\xect\xc5\xa1\x86V\xbe\xa7MZJWII\x86\xb9Pn\xcdh\xa0\x07\xc2\x1d', total iters: 43172559927875

New Behavior:

Updated timelord peak to 142a52586c6c65f69ba99f45c596f45b449e8632a7dc03e756ec1373fae0511d, total iters: 43172559927875

Testing Notes:

No additional tests needed.

@hoffmang9 hoffmang9 requested a review from a team as a code owner August 13, 2024 23:08
@hoffmang9 hoffmang9 added timelord Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Logging Change output to .chia/NETWORK/log/debug.log labels Aug 13, 2024
@hoffmang9
Copy link
Member Author

Confirmed working on rocket04

@arvidn
Copy link
Contributor

arvidn commented Aug 14, 2024

technically, this is an issue in chia_rs's python bindings. That function returns a plain bytes, even though the type stubs says bytes32. There's nothing wrong with this fix though, it will work.

@arvidn
Copy link
Contributor

arvidn commented Aug 14, 2024

Chia-Network/chia_rs#664

@Starttoaster Starttoaster merged commit bd022b0 into main Aug 15, 2024
374 checks passed
@Starttoaster Starttoaster deleted the hoffmang9-tl-log-string branch August 15, 2024 16:08
@altendky altendky mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Logging Change output to .chia/NETWORK/log/debug.log ready_to_review timelord
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants