CHIA-902 make Program.run() and Program.run_with_cost() default to enabling all the most recent features #18370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
richardkiss
reviewed
Jul 30, 2024
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
merge_conflict
richardkiss
previously approved these changes
Aug 1, 2024
arvidn
changed the title
richardkiss
approved these changes
Aug 7, 2024
emlowe
approved these changes
Aug 7, 2024
|
There doesn't seem much difference now between |
Yeah, as I mentioned above maybe we consider deprecating it. |
|
Waiting on merge for all conversations to reach a resolution. |
|
the difference is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This is a follow-up on #18287
This came out of a conversation with @trepca . Testing puzzles that use features from recent soft-forks (and the hard fork) is made more difficult because the default
run()functions don't enable those features. This patch fixes that by enabling everything.It also runs in mempool-mode by default.
Additionally, a new
run()variant is added to control exactly which features (flags) are enabled.Current Behavior:
Program.run()does not support new opcodes, and ignores unknown ones.New Behavior:
Program.run()does supports new opcodes, and fails on unknown ones.