[CHIA-819] Fix 12-word mnemonic support in keychain #18246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Fixed
Quexington
changed the title
emlowe
previously approved these changes
Jun 25, 2024
Quexington
force-pushed
the
quex.fix_12_word_mnemonic
branch
from
f44197f to
045131d
Compare
altendky
requested review from
emlowe
and removed request for
a team and
altendky
emlowe
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an accidental regression introduced in 2.4.0 which caused 12-word mnemonics, once stored in the keychain, to lose access to the secret information. The information was still present in the keychain, the daemon just couldn't access it.
#18243