Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix for make_spend function #18131

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

trepca
Copy link
Contributor

@trepca trepca commented Jun 7, 2024

raise error when passing wrong type to make_spend to avoid ambiguous UnboundLocalError exception

@trepca trepca requested a review from a team as a code owner June 7, 2024 10:04
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jun 7, 2024
@cmmarslender cmmarslender reopened this Jun 10, 2024
Copy link

coveralls-official bot commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9456404985

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 27 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.883%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/types/coin_spend.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 72.57%
chia/farmer/farmer.py 1 72.23%
chia/wallet/wallet_node.py 1 89.01%
chia/_tests/core/full_node/test_transactions.py 1 99.11%
chia/daemon/client.py 1 73.33%
chia/timelord/timelord.py 2 73.67%
chia/data_layer/data_layer.py 2 85.32%
chia/full_node/full_node.py 3 85.96%
chia/_tests/core/util/test_lockfile.py 4 88.26%
chia/server/server.py 4 81.46%
Totals Coverage Status
Change from base Build 9432246969: -0.02%
Covered Lines: 99973
Relevant Lines: 109941

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Jun 11, 2024

coverage:

chia/types/coin_spend.py (0.0%): Missing lines 34,40

@cmmarslender cmmarslender merged commit a5be6eb into Chia-Network:main Jun 12, 2024
706 of 712 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog community-pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants