[CHIA-711] Add WalletActionScope
#18125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
changed the title
WalletActionScopeWalletActionScope
github-actions
bot
added
the
merge_conflict
Quexington
added
the
Added
github-actions
bot
removed
the
merge_conflict
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
geoffwalmsley
approved these changes
Jun 21, 2024
markelrod
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a usage of the new
ActionScopeprimitive for the wallet's use cases. The idea is primarily to give a place for every transaction method to put their transactions and look at the transactions that have already been generated. It hooks into.add_pending_transactionswhich is the primary endpoint for adding transaction state changes to the database. This function was tweaked (hiding whitespace will help in review) to work better with the paradigm. It should probably be multiple functions and the only endpoint should be the action scope, but that feels out of scope for this change.