Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance tweaks #17155

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Performance tweaks #17155

merged 3 commits into from
Dec 22, 2023

Conversation

wjblanke
Copy link
Contributor

@wjblanke wjblanke commented Dec 22, 2023 •
edited
Loading

Purpose:

Performance tweaks

Current Behavior:

config.yaml peer count init'd to 80
db_sync defaults to FULL

New Behavior:

config.yaml peer count init'd to 40
db_sync defaults to NORMAL

Testing Notes:

@wjblanke wjblanke added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Dec 22, 2023
@wjblanke wjblanke requested a review from a team as a code owner December 22, 2023 18:53
@wjblanke wjblanke requested review from emlowe and arvidn December 22, 2023 20:25
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 7303109379

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage remained the same at 90.467%
Files with Coverage Reduction New Missed Lines %
chia/rpc/util.py 1 93.22%
chia/data_layer/data_layer_wallet.py 2 91.09%
chia/full_node/full_node.py 2 85.2%
chia/full_node/weight_proof.py 4 90.73%
chia/server/node_discovery.py 4 79.55%
Totals Coverage Status
Change from base Build 7294432788: 0.0%
Covered Lines: 93867
Relevant Lines: 103714
💛 - Coveralls

@cmmarslender cmmarslender merged commit a4cab82 into release/2.1.4 Dec 22, 2023
576 checks passed
@cmmarslender cmmarslender deleted the syncnpeerswjb branch December 22, 2023 22:28
mikehw pushed a commit to mikehw/chia-blockchain that referenced this pull request Jan 11, 2024
@wjblanke @mikehw
Performance tweaks (Chia-Network#17155)
8a9d3a7 
* changed default peers from 80 to 40. switched auto db_sync default to NORMAL instead of FULL

* fixed default

* add defaults to config query
josinaldobarbosa
josinaldobarbosa reviewed Jan 12, 2024
View reviewed changes
chia/util/initial-config.yaml
@@ -408,7 +408,7 @@ full_node:
# How long to wait for a peer connection
peer_connect_timeout: 30
# Accept peers until this number of connections
target_peer_count: 80
target_peer_count: 40
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed automatically when updating, most users won't look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josinaldobarbosa josinaldobarbosa josinaldobarbosa left review comments

@arvidn arvidn arvidn approved these changes

@emlowe emlowe Awaiting requested review from emlowe

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjblanke @arvidn @josinaldobarbosa @cmmarslender