Adjust ban times for DL dat files #17021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a file is downloaded, but fails to insert properly, we ban that server for 7 days. In this case, the files can fail to insert for a variety of reasons, such as a truncated download, or disk problem that is likely not a result of a malicious actor.
This ban is overly long and has caused some problems with both CADT and Labrador.
This PR uses the logic for missing files to set a progressive ban per attempt with a maximum of one hour. This is using an existing function for this and so has very little risk. We would like to get into 2.1.2 so we can update CADT with this change
Change made in agreement with Zach and Ken.